Skip to content

nixos/test/login: Fix uaccess test.#453603

Merged
ElvishJerricco merged 1 commit intoNixOS:staging-nextfrom
ElvishJerricco:push-twrwnqttwnky
Oct 20, 2025
Merged

nixos/test/login: Fix uaccess test.#453603
ElvishJerricco merged 1 commit intoNixOS:staging-nextfrom
ElvishJerricco:push-twrwnqttwnky

Conversation

@ElvishJerricco
Copy link
Contributor

@ElvishJerricco ElvishJerricco commented Oct 19, 2025

This PR systemd/systemd#36444 caused this bug systemd/systemd#39043, which is fixed in this PR systemd/systemd#39071. In short, uaccess doesn't work with OPTIONS+="static_node=..." udev rules, and /dev/snd/timer is a static node. 258.1 needs to wait for the next staging cycle, so for now let's just use a non-static node.

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@ElvishJerricco
nixos/test/login: Fix uaccess test.
67e1598 
This PR systemd/systemd#36444 caused this bug
systemd/systemd#39043, which is fixed in
this PR systemd/systemd#39071. In short,
`uaccess` doesn't work with `OPTIONS+="static_node=..."` udev rules,
and `/dev/snd/timer` is a static node. 258.1 needs to wait for the
next staging cycle, so for now let's just use a non-static node.
@ElvishJerricco ElvishJerricco requested review from a team, dramforever and vcunat October 19, 2025 20:24
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS labels Oct 19, 2025
@ElvishJerricco ElvishJerricco marked this pull request as draft October 19, 2025 21:52
@ElvishJerricco ElvishJerricco marked this pull request as ready for review October 19, 2025 23:01
dramforever
dramforever approved these changes Oct 20, 2025
View reviewed changes
Copy link
Contributor

@dramforever dramforever left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested nixosTests.login and nixosTests.latestKernel.login on aarch64-linux

Bummer that we're shipping 258 to users with a known regression, but this really hopefully should be work-around-able.

@nixpkgs-ci nixpkgs-ci bot added the 12.approvals: 1 This PR was reviewed and approved by one person. label Oct 20, 2025
@ElvishJerricco ElvishJerricco mentioned this pull request Oct 20, 2025
Merged
13 tasks
@ElvishJerricco ElvishJerricco added this pull request to the merge queue Oct 20, 2025
Merged via the queue into NixOS:staging-next with commit 0238bbc Oct 20, 2025
32 of 35 checks passed
@ElvishJerricco ElvishJerricco deleted the push-twrwnqttwnky branch October 20, 2025 05:02
This was referenced Oct 20, 2025
Merged
Merged
@vcunat
Copy link
Member

vcunat commented Oct 21, 2025

Ah, though there are more tests:

nixos/tests/budgie.nix:          machine.succeed("getfacl -p /dev/snd/timer | grep -q ${user.name}")
nixos/tests/cinnamon-wayland.nix:          machine.succeed("getfacl -p /dev/snd/timer | grep -q ${user.name}")
nixos/tests/cinnamon.nix:          machine.succeed("getfacl -p /dev/snd/timer | grep -q ${user.name}")
nixos/tests/enlightenment.nix:          machine.succeed("getfacl -p /dev/snd/timer | grep -q ${user.name}")
nixos/tests/gnome-extensions.nix:          assert "alice" in machine.succeed("getfacl -p /dev/snd/timer")
nixos/tests/gnome-flashback.nix:          assert "alice" in machine.succeed("getfacl -p /dev/snd/timer")
nixos/tests/gnome-xorg.nix:          assert "alice" in machine.succeed("getfacl -p /dev/snd/timer")
nixos/tests/gnome.nix:          assert "alice" in machine.succeed("getfacl -p /dev/snd/timer")
nixos/tests/login.nix:        # Change back to /dev/snd/timer after systemd-258.1
nixos/tests/lxqt.nix:          machine.succeed("getfacl -p /dev/snd/timer | grep -q ${user.name}")
nixos/tests/mate.nix:          machine.succeed("getfacl -p /dev/snd/timer | grep -q ${user.name}")
nixos/tests/pantheon.nix:          machine.succeed("getfacl -p /dev/snd/timer | grep -q ${user.name}")
nixos/tests/xfce-wayland.nix:        machine.succeed("getfacl -p /dev/snd/timer | grep -q ${user.name}")
nixos/tests/xfce.nix:        machine.succeed("getfacl -p /dev/snd/timer | grep -q ${user.name}")

And some of these are nixos-unstable blockers.

@ElvishJerricco ElvishJerricco mentioned this pull request Oct 22, 2025
Merged
13 tasks
ElvishJerricco added a commit to ElvishJerricco/nixpkgs that referenced this pull request Oct 22, 2025
@ElvishJerricco
nixos/tests: More temporary uaccess fixes
b22b5a3 
See: NixOS#453603
@bendlas
Copy link
Contributor

bendlas commented Nov 24, 2025

I found this, when looking at systemd/systemd#36444

The corresponding upstream commit (systemd/systemd@c960ca2) introduced a regression to one of my machines:

  • Run startx on a tty
  • Switch to a different tty
  • Switch back
    • REGRESSION screen stays blank
  • When trying to to switch to another tty again, chvt blocks until the startx process is killed

It looks like the test failures in NixOS were "fixed temporarily". I'm wondering where we are in resolving these permanently / investigating root causes. I've switched back to systemd 257 for now. Would be happy to help debug this.

@dramforever
Copy link
Contributor

dramforever commented Nov 24, 2025

@bendlas

I'm wondering where we are in resolving these permanently / investigating root causes.

Already fixed in #453713

Your problem is separate - please open a different issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dramforever dramforever dramforever approved these changes

@vcunat vcunat Awaiting requested review from vcunat

Assignees

No one assigned

Labels

6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ElvishJerricco @vcunat @bendlas @dramforever