Skip to content

infamousPlugins: fix build with cmake 4#453600

Merged
vcunat merged 1 commit intoNixOS:masterfrom
magnetophon:infamousPlugins
Oct 27, 2025
Merged

infamousPlugins: fix build with cmake 4#453600
vcunat merged 1 commit intoNixOS:masterfrom
magnetophon:infamousPlugins

Conversation

@magnetophon
Copy link
Member

@magnetophon magnetophon commented Oct 19, 2025 •
edited
Loading

Tracking issue #445447

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 9.needs: reviewer This PR currently has no reviewers requested and needs attention. labels Oct 19, 2025
@Sigmanificient Sigmanificient mentioned this pull request Oct 19, 2025
Open
@mdaniels5757
Copy link
Member

mdaniels5757 commented Oct 19, 2025

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 453600 --build-args='-L'
Commit: 514da3ac5bc54f0db0ebc347d78b1bb5262a8fdb (subsequent changes)
Merge: 36bea04e5046506bdccda37fa9ad7f29d3df4067

Logs: https://github.com/mdaniels5757/nixpkgs-review-gha/actions/runs/18636813982

x86_64-linux

✅ 1 package built:
  • infamousPlugins

aarch64-linux

✅ 1 package built:
  • infamousPlugins

x86_64-darwin

✅ No rebuilds

aarch64-darwin

✅ No rebuilds

mdaniels5757
mdaniels5757 approved these changes Oct 19, 2025
View reviewed changes
Copy link
Member

@mdaniels5757 mdaniels5757 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved automatically following the successful run of nixpkgs-review.

@nixpkgs-ci nixpkgs-ci bot added 12.approvals: 1 This PR was reviewed and approved by one person. and removed 9.needs: reviewer This PR currently has no reviewers requested and needs attention. labels Oct 19, 2025
iedame
iedame approved these changes Oct 27, 2025
View reviewed changes
Copy link
Contributor

@iedame iedame left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nixpkgs-ci nixpkgs-ci bot added 12.approvals: 2 This PR was reviewed and approved by two persons. and removed 12.approvals: 1 This PR was reviewed and approved by one person. labels Oct 27, 2025
@vcunat vcunat added this pull request to the merge queue Oct 27, 2025
Merged via the queue into NixOS:master with commit db5dad0 Oct 27, 2025
39 of 40 checks passed
@magnetophon magnetophon deleted the infamousPlugins branch November 1, 2025 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mdaniels5757 mdaniels5757 mdaniels5757 approved these changes

+1 more reviewer

@iedame iedame iedame approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 12.approvals: 2 This PR was reviewed and approved by two persons.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@magnetophon @mdaniels5757 @iedame @vcunat