Skip to content

unnamed-sdvx-clone: fix build failure with cmake 4#453596

Closed
Sakooooo wants to merge 1 commit intoNixOS:masterfrom
Sakooooo:unnamed-sdvx-clone-cmake-fix
Closed

unnamed-sdvx-clone: fix build failure with cmake 4#453596
Sakooooo wants to merge 1 commit intoNixOS:masterfrom
Sakooooo:unnamed-sdvx-clone-cmake-fix

Conversation

@Sakooooo
Copy link
Contributor

@Sakooooo Sakooooo commented Oct 19, 2025

Add -DCMAKE_POLICY_VERSION_MINIMUM=3.5 to cmakeFlags to fix build failure.

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@Sakooooo Sakooooo mentioned this pull request Oct 19, 2025
Closed
3 tasks
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Oct 19, 2025
@nixpkgs-ci nixpkgs-ci bot added the 9.needs: reviewer This PR currently has no reviewers requested and needs attention. label Oct 19, 2025
@mdaniels5757 mdaniels5757 mentioned this pull request Oct 19, 2025
Merged
13 tasks
@mdaniels5757
Copy link
Member

mdaniels5757 commented Oct 19, 2025

Upstream has already fixed this, so I think updating is preferable. I made a PR at #453634.

@Sakooooo
Copy link
Contributor Author

Sakooooo commented Oct 20, 2025

See #453634

@Sakooooo Sakooooo closed this Oct 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

9.needs: reviewer This PR currently has no reviewers requested and needs attention. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Sakooooo @mdaniels5757