Skip to content

ChowKick: fix build with cmake 4#453577

Merged
symphorien merged 1 commit intoNixOS:masterfrom
magnetophon:ChowKick
Oct 22, 2025
Merged

ChowKick: fix build with cmake 4#453577
symphorien merged 1 commit intoNixOS:masterfrom
magnetophon:ChowKick

Conversation

@magnetophon
Copy link
Member

@magnetophon magnetophon commented Oct 19, 2025 •
edited
Loading

Tracking issue #445447

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@Sigmanificient Sigmanificient mentioned this pull request Oct 19, 2025
Open
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Oct 19, 2025
mdaniels5757
mdaniels5757 reviewed Oct 20, 2025
View reviewed changes
Copy link
Member

@mdaniels5757 mdaniels5757 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs nixfmt to be run.

@magnetophon magnetophon mentioned this pull request Oct 20, 2025
Merged
13 tasks
@mdaniels5757
Copy link
Member

mdaniels5757 commented Oct 20, 2025

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 453577 --build-args='-L'
Commit: f756d8f6d7d46b8ae95249acd7c398f0f67418d5 (subsequent changes)
Merge: f206b47df06a89d63bb418b5404cce0de75f014d

Logs: https://github.com/mdaniels5757/nixpkgs-review-gha/actions/runs/18639026624

x86_64-linux

✅ 1 package built:
  • chow-kick

aarch64-linux

✅ 1 package built:
  • chow-kick

mdaniels5757
mdaniels5757 approved these changes Oct 20, 2025
View reviewed changes
Copy link
Member

@mdaniels5757 mdaniels5757 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved automatically following the successful run of nixpkgs-review.

@nixpkgs-ci nixpkgs-ci bot added the 12.approvals: 1 This PR was reviewed and approved by one person. label Oct 20, 2025
@symphorien
Copy link
Member

symphorien commented Oct 22, 2025

I have no idea how to use chowkick but inside nixpkgs-review it segfaults on --help:

[nix-shell:~/.cache/nixpkgs-review/pr-453577]$ results/chow-kick-x86_64-linux/bin/ChowKick  --help
Segmentation fault         (core dumped)results/chow-kick-x86_64-linux/bin/ChowKick --help

is it normal ?

@magnetophon
Copy link
Member Author

magnetophon commented Oct 22, 2025

@symphorien Yes, unfortunately the standalone version (the binary you tried to run) has been broken for a while now.
Not sure when it started or what causes it.
Fortunately, 99% of people will not need that and will use the plugin version instead, usually inside a DAW (Digital Audio Workstation).
You can test with: carla-single vst3 /nix/store/gbkds270gbrnjjxdl1dws20pqdkq8xag-chow-kick-1.2.0/lib/vst3/ChowKick.vst3/ (Change the store path as needed).
The binary carla-single can be installed with: nix profile add nixpkgs#carla.

@symphorien
Copy link
Member

symphorien commented Oct 22, 2025

Apparently I need jack for it to work so I'll trust the maintainer on this one :)

@symphorien symphorien added this pull request to the merge queue Oct 22, 2025
Merged via the queue into NixOS:master with commit d021519 Oct 22, 2025
28 of 31 checks passed
@magnetophon magnetophon deleted the ChowKick branch November 1, 2025 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mdaniels5757 mdaniels5757 mdaniels5757 approved these changes

Assignees

No one assigned

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@magnetophon @mdaniels5757 @symphorien