Skip to content

far2l: fix build issue related to cmake 4#453567

Merged
vcunat merged 1 commit intoNixOS:masterfrom
andrewzah:far2l
Oct 27, 2025
Merged

far2l: fix build issue related to cmake 4#453567
vcunat merged 1 commit intoNixOS:masterfrom
andrewzah:far2l

Conversation

@andrewzah
Copy link
Contributor

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Oct 19, 2025
@nix-owners nix-owners bot requested a review from hypersw October 19, 2025 17:22
@nixpkgs-ci nixpkgs-ci bot added 9.needs: reviewer This PR currently has no reviewers requested and needs attention. and removed 9.needs: reviewer This PR currently has no reviewers requested and needs attention. labels Oct 19, 2025
@andrewzah
Copy link
Contributor Author

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 453567
Commit: 7c594b9cc79989b9d244733334d360900aec2559 (subsequent changes)
Merge: c21f58a43a26253d36b28e45c370fdeeb295d41d

Logs: https://github.com/andrewzah/nixpkgs-review-gha/actions/runs/18633618339


x86_64-linux

✅ 1 package built:
  • far2l

aarch64-linux

✅ 1 package built:
  • far2l

x86_64-darwin (sandbox = true)

✅ 1 package built:
  • far2l

aarch64-darwin (sandbox = true)

✅ 1 package built:
  • far2l

@andrewzah
Copy link
Contributor Author

@iedame implemented the requested changes.

@andrewzah
Copy link
Contributor Author

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 453567
Commit: e1afd1e79d21c9c74463aa8966aed72f91599d27 (subsequent changes)
Merge: 541eed0adbf25ab35e9a571b47c4fa8b8b0a5c3e

Logs: https://github.com/andrewzah/nixpkgs-review-gha/actions/runs/18832709998


x86_64-linux

✅ 1 package built:
  • far2l

aarch64-linux

✅ 1 package built:
  • far2l

x86_64-darwin (sandbox = true)

✅ 1 package built:
  • far2l

aarch64-darwin (sandbox = true)

✅ 1 package built:
  • far2l

@vcunat vcunat added this pull request to the merge queue Oct 27, 2025
Merged via the queue into NixOS:master with commit aa9a9de Oct 27, 2025
27 of 30 checks passed
@andrewzah andrewzah deleted the far2l branch October 27, 2025 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants