openboardview: update to 9.95.2 supporting cmake 4, a new update.sh script#453563
openboardview: update to 9.95.2 supporting cmake 4, a new update.sh script#453563k3a wants to merge 2 commits intoNixOS:masterfrom
Conversation
nixpkgs-ci
bot
added
10.rebuild-linux: 1-10
|
k3a
force-pushed
the
openboardview-9.95.2
branch
from
be46def to
93016e9
Compare
|
This PR now includes a single patch, which has been merged to the master of the OpenBoardView. In comparison to the previous version, it now includes an improved update.sh script which is using GitHub API to fetch the tag of the latest release. |
|
|
Tested locally on x86_64 and the updated derivation builds a working openboardview. |
| passthru.updateScript = gitUpdater { | ||
| ignoredVersions = ''.*\.90\..*''; | ||
| }; | ||
| passthru.updateScript = ./update.sh; |
There was a problem hiding this comment.
How is it different from nix-update-script?
There was a problem hiding this comment.
Same reason as for other packages that match
grep -r 'api.github.com.*release' NIXPKGS_ROOT | less — it retrieves the latest GitHub Release tag.
The built-in update script doesn’t use the GitHub API; it simply fetches the latest git tag. However, in the past, OpenBoardView has published some pre-release versions, which we’re not interested in — we only want official Releases.
There was a problem hiding this comment.
Why not just configuring gitUpdater with allowedVersions = "^[0-9\\.]+$"?
There was a problem hiding this comment.
Because it's not so simply regular, please look at the release history and note releases marked as pre-release: https://github.com/OpenBoardView/OpenBoardView/releases?page=1
There was a problem hiding this comment.
This regex ignores pre-releases and only covers the stable releases.
There was a problem hiding this comment.
Ah... The GitHub releases are marked with pre-release, alpha and beta but not the tags. Sigh.
There was a problem hiding this comment.
Could you please separate out the version bump from the rest? I would like to get this in ASAP. We can look at the updater script later.
There was a problem hiding this comment.
ASAP? What’s stopping you from taking the package.nix file and building the new version locally on your computer?!
We need a proper updater script so that future updates are automatic and exclude pre-releases. Nix aims to maintain an up-to-date package repository by using update scripts. I wrote an update script based on many others in this repo.
The previous ignore regexp with a standard updater excluded recent OpenBoardView versions because it wasn’t sufficient. OpenBoardView uses GitHub’s release functionality to distinguish between releases and pre-releases.
So please look at the updater script now, it's just 16 script lines. I’ve already resolved the macOS build problem by submitting this PR upstream, simplifying the updates into just hash changes. Anyone can generate the hash for the new version - but what really matters now is that update script!
There was a problem hiding this comment.
ASAP? What’s stopping you from taking the
package.nixfile and building the new version locally on your computer?!
Why would I apply local hacks while the fix is dead simple and could have been merged weeks ago? Now the package is not just broken on unstable but also on the 25.11 branch. Great. But yeah.. don't mind it. The updater script is what matters. Sure.
There was a problem hiding this comment.
Building a package from package.nix file is not a hack.
Obviously I didn't expect that making this simple updater script based on existing ones would cause the PR to be delayed for more than a month. :( If I knew, I would split it right away!
I did my part of work, sadly, no one was able to review the updater, including you (it seems).
|
OpenBoardView releases are quite a mess. Versions .90. are alpha, .95. are beta. owever, non-.90 and non-.95 versions can no longer be easily compiled with recent compilers, so we’re essentially forced to accept at least beta releases. Pre-releases were used in the past, but they haven’t proven particularly useful. Closing this in favor of a simple update #465066 for now. Will consider re-reintroducing the update script in the future in case there is a stronger need for it. |
7 participants
A new update.sh script to fetch the latest release which is not a pre-release.
Updates the version to the latest one, including a patch fixing build on darwin.
Replaces #452764.
References: OpenBoardView/OpenBoardView#340
Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.Add a 👍 reaction to pull requests you find important.