Skip to content

dkh: fix build issue due to cmake 4#453561

Merged
Sigmanificient merged 1 commit intoNixOS:masterfrom
andrewzah:dkh
Oct 20, 2025
Merged

dkh: fix build issue due to cmake 4#453561
Sigmanificient merged 1 commit intoNixOS:masterfrom
andrewzah:dkh

Conversation

@andrewzah
Copy link
Contributor

@andrewzah andrewzah commented Oct 19, 2025

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@Sigmanificient Sigmanificient mentioned this pull request Oct 19, 2025
Open
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Oct 19, 2025
@nix-owners nix-owners bot requested a review from sheepforce October 19, 2025 17:06
@andrewzah
Copy link
Contributor Author

andrewzah commented Oct 19, 2025

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 453561
Commit: f8ddb0304cff948ea8add21ab3f102dbcf65b3fb (subsequent changes)
Merge: 4b365aa758bf9a340e6ac34709a2f817c56e2cc1

Logs: https://github.com/andrewzah/nixpkgs-review-gha/actions/runs/18633431329

x86_64-linux

✅ 1 package built:
  • dkh

aarch64-linux

✅ 1 package built:
  • dkh

x86_64-darwin (sandbox = true)

✅ 1 package built:
  • dkh

aarch64-darwin (sandbox = true)

✅ 1 package built:
  • dkh

@nixpkgs-ci nixpkgs-ci bot added 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. labels Oct 20, 2025
@Sigmanificient Sigmanificient added this pull request to the merge queue Oct 20, 2025
Merged via the queue into NixOS:master with commit d7f6939 Oct 20, 2025
33 of 36 checks passed
@andrewzah andrewzah deleted the dkh branch October 20, 2025 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@sheepforce sheepforce sheepforce approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@andrewzah @sheepforce @Sigmanificient