Skip to content

zed-open-capture: fix build with cmake4, modernize#453525

Merged
wegank merged 1 commit intoNixOS:masterfrom
iedame:fix/zed-open-capture
Oct 25, 2025
Merged

zed-open-capture: fix build with cmake4, modernize#453525
wegank merged 1 commit intoNixOS:masterfrom
iedame:fix/zed-open-capture

Conversation

@iedame
Copy link
Contributor

@iedame iedame commented Oct 19, 2025

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. labels Oct 19, 2025
@nix-owners nix-owners bot requested a review from marius851000 October 19, 2025 12:47
@iedame

This comment was marked as outdated.

@iedame iedame force-pushed the fix/zed-open-capture branch from 2a4ab27 to 57d1428 Compare October 19, 2025 19:30
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. and removed 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. labels Oct 19, 2025
@iedame
Copy link
Contributor Author

iedame commented Oct 19, 2025

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 453525
Commit: 57d14289a605a0844aa4aebf61ec135f2979c123 (subsequent changes)
Merge: a1243fc4d25b216cb26d405f92de7e66f41aeb08

Logs: https://github.com/iedame/nixpkgs-review-gha/actions/runs/18635126987


x86_64-linux

✅ 2 packages built:
  • rtabmap
  • zed-open-capture

aarch64-linux

✅ 2 packages built:
  • rtabmap
  • zed-open-capture

x86_64-darwin

No rebuilds


aarch64-darwin

No rebuilds

@nim65s nim65s mentioned this pull request Oct 22, 2025
13 tasks
@wegank wegank added this pull request to the merge queue Oct 25, 2025
Merged via the queue into NixOS:master with commit 7bf9a51 Oct 25, 2025
29 of 31 checks passed
@iedame iedame deleted the fix/zed-open-capture branch October 25, 2025 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants