Skip to content

swiftshader: 2023-09-11 -> 2025-10-15, fix CMake 4.0 build#453524

Merged
Sigmanificient merged 2 commits intoNixOS:masterfrom
nekowinston:swiftshader/cmake-fix-and-bump
Oct 23, 2025
Merged

swiftshader: 2023-09-11 -> 2025-10-15, fix CMake 4.0 build#453524
Sigmanificient merged 2 commits intoNixOS:masterfrom
nekowinston:swiftshader/cmake-fix-and-bump

Conversation

@nekowinston
Copy link
Member

@nekowinston nekowinston commented Oct 19, 2025 •
edited
Loading

Related: #445447

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 9.needs: reviewer This PR currently has no reviewers requested and needs attention. labels Oct 19, 2025
@Sigmanificient Sigmanificient mentioned this pull request Oct 19, 2025
Open
@Sigmanificient
Copy link
Member

Sigmanificient commented Oct 20, 2025

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 453524
Commit: d62d487e8861624ea9281d704952721d959f06fa (subsequent changes)
Merge: a46ef87c7cb9f66af4c1b09bb3b95bce3643dae3

Logs: https://github.com/Sigmanificient/nixpkgs-review-gha/actions/runs/18638970722

x86_64-linux

✅ 1 package built:
  • swiftshader

aarch64-linux

✅ 1 package built:
  • swiftshader

mdaniels5757
mdaniels5757 approved these changes Oct 22, 2025
View reviewed changes
Copy link
Member

@mdaniels5757 mdaniels5757 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Diff and nixpkgs-review LGTM.

@nixpkgs-ci nixpkgs-ci bot added 12.approvals: 1 This PR was reviewed and approved by one person. and removed 9.needs: reviewer This PR currently has no reviewers requested and needs attention. labels Oct 22, 2025
@Sigmanificient Sigmanificient added this pull request to the merge queue Oct 23, 2025
Merged via the queue into NixOS:master with commit 9e35d6a Oct 23, 2025
34 of 36 checks passed
@nekowinston nekowinston deleted the swiftshader/cmake-fix-and-bump branch October 25, 2025 23:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mdaniels5757 mdaniels5757 mdaniels5757 approved these changes

Assignees

No one assigned

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@nekowinston @Sigmanificient @mdaniels5757