Skip to content

otb: fix minimum cmake version error#453492

Merged
GaetanLepage merged 1 commit intoNixOS:masterfrom
daspk04:fix-otb
Oct 19, 2025
Merged

otb: fix minimum cmake version error#453492
GaetanLepage merged 1 commit intoNixOS:masterfrom
daspk04:fix-otb

Conversation

@daspk04
Copy link
Contributor

@daspk04 daspk04 commented Oct 19, 2025

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

* Update the cmake version to 3.10 for ITK third-party related module
@daspk04 daspk04 self-assigned this Oct 19, 2025
@daspk04 daspk04 requested a review from GaetanLepage October 19, 2025 10:06
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. labels Oct 19, 2025
@GaetanLepage
Copy link
Contributor

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 453492
Commit: a30bedbc214b7bcdcd462e03017f36e2828a7844


x86_64-linux

❌ 5 packages failed to build:
  • otb
  • python312Packages.pyotb
  • python312Packages.pyotb.dist
  • python313Packages.pyotb
  • python313Packages.pyotb.dist

aarch64-linux

❌ 5 packages failed to build:
  • otb
  • python312Packages.pyotb
  • python312Packages.pyotb.dist
  • python313Packages.pyotb
  • python313Packages.pyotb.dist

@daspk04
Copy link
Contributor Author

daspk04 commented Oct 19, 2025

Hi @GaetanLepage !

This relies on MR, so once it is merged the otb should build fine, just waiting for it to be merged so I can rebase.

@GaetanLepage
Copy link
Contributor

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 453492
Commit: a30bedbc214b7bcdcd462e03017f36e2828a7844


x86_64-linux

✅ 5 packages built:
  • otb
  • python312Packages.pyotb
  • python312Packages.pyotb.dist
  • python313Packages.pyotb
  • python313Packages.pyotb.dist

aarch64-linux

✅ 5 packages built:
  • otb
  • python312Packages.pyotb
  • python312Packages.pyotb.dist
  • python313Packages.pyotb
  • python313Packages.pyotb.dist

Copy link
Contributor

@GaetanLepage GaetanLepage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@GaetanLepage GaetanLepage added this pull request to the merge queue Oct 19, 2025
Merged via the queue into NixOS:master with commit ad0cf0a Oct 19, 2025
29 of 33 checks passed
@nixpkgs-ci nixpkgs-ci bot added the 12.approvals: 1 This PR was reviewed and approved by one person. label Oct 19, 2025
@daspk04
Copy link
Contributor Author

daspk04 commented Oct 19, 2025

Thanks @GaetanLepage !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants