Skip to content

galario: fix build issue related to cmake 4.#453473

Merged
vcunat merged 1 commit intoNixOS:masterfrom
andrewzah:galario
Oct 27, 2025
Merged

galario: fix build issue related to cmake 4.#453473
vcunat merged 1 commit intoNixOS:masterfrom
andrewzah:galario

Conversation

@andrewzah
Copy link
Contributor

@andrewzah andrewzah commented Oct 19, 2025

As noted in #445447.

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. labels Oct 19, 2025
@nix-owners nix-owners bot requested a review from smaret October 19, 2025 09:18
@andrewzah
Copy link
Contributor Author

andrewzah commented Oct 19, 2025

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 453473
Commit: 985946b91261a5acd0cbe1ab7fab963e9b611645 (subsequent changes)
Merge: 95bd56d3d35b4bdfd4b126e219d6b5f979b81599

Logs: https://github.com/andrewzah/nixpkgs-review-gha/actions/runs/18628331207

x86_64-linux

❌ 1 package failed to build:
  • python312Packages.galario
✅ 1 package built:
  • galario
Error logs: `x86_64-linux`
python312Packages.galario 
    from scipy.integrate import trapezoid, quadrature
E   ImportError: cannot import name 'quadrature' from 'scipy.integrate' (/nix/store/l06c2lyamcmgq5ndk5s70jdgzla1dy56-python3.12-scipy-1.16.1/lib/python3.12/site-packages/scipy/integrate/__init__.py)
=========================== short test summary info ============================
ERROR ../python_package/tests/test_galario.py
!!!!!!!!!!!!!!!!!!!! Interrupted: 1 error during collection !!!!!!!!!!!!!!!!!!!!
=============================== 1 error in 0.99s ===============================

67% tests passed, 1 tests failed out of 3


Label Time Summary:

pytest    =   1.53 secproc (1 test)

python    =   1.53 secproc (1 test)


Total Test time (real) =   1.53 sec


The following tests FAILED:

3 - galario (Failed)                                  pytest python

Errors while running CTest

make: *** [Makefile:71: test] Error 8

aarch64-linux

❌ 1 package failed to build:
  • python312Packages.galario
✅ 1 package built:
  • galario
Error logs: `aarch64-linux`
python312Packages.galario 
    from scipy.integrate import trapezoid, quadrature
E   ImportError: cannot import name 'quadrature' from 'scipy.integrate' (/nix/store/l5s10a40larx5x3zdg11p37rc1p7w3f6-python3.12-scipy-1.16.1/lib/python3.12/site-packages/scipy/integrate/__init__.py)
=========================== short test summary info ============================
ERROR ../python_package/tests/test_galario.py
!!!!!!!!!!!!!!!!!!!! Interrupted: 1 error during collection !!!!!!!!!!!!!!!!!!!!
=============================== 1 error in 0.81s ===============================

67% tests passed, 1 tests failed out of 3


Label Time Summary:

pytest    =   1.23 secproc (1 test)

python    =   1.23 secproc (1 test)


Total Test time (real) =   1.23 sec


The following tests FAILED:

3 - galario (Failed)                                  pytest python

Errors while running CTest

make: *** [Makefile:71: test] Error 8

x86_64-darwin (sandbox = true)

❌ 1 package failed to build:
  • python312Packages.galario
✅ 1 package built:
  • galario
Error logs: `x86_64-darwin`
python312Packages.galario 
    from scipy.integrate import trapezoid, quadrature
E   ImportError: cannot import name 'quadrature' from 'scipy.integrate' (/nix/store/azsncx1p73rnmxagfj4p3vg6b776kijg-python3.12-scipy-1.16.1/lib/python3.12/site-packages/scipy/integrate/__init__.py)
=========================== short test summary info ============================
ERROR ../python_package/tests/test_galario.py
!!!!!!!!!!!!!!!!!!!! Interrupted: 1 error during collection !!!!!!!!!!!!!!!!!!!!
============================== 1 error in 33.40s ===============================

67% tests passed, 1 tests failed out of 3


Label Time Summary:

pytest    =  37.43 secproc (1 test)

python    =  37.43 secproc (1 test)


Total Test time (real) =  37.45 sec


The following tests FAILED:

3 - galario (Failed)                                  pytest python

Errors while running CTest

make: *** [Makefile:71: test] Error 8

aarch64-darwin (sandbox = true)

❌ 1 package failed to build:
  • python312Packages.galario
✅ 1 package built:
  • galario
Error logs: `aarch64-darwin`
python312Packages.galario 
    from scipy.integrate import trapezoid, quadrature
E   ImportError: cannot import name 'quadrature' from 'scipy.integrate' (/nix/store/69kmcz5wg71s13h59r4xccxkh94s9nhi-python3.12-scipy-1.16.1/lib/python3.12/site-packages/scipy/integrate/__init__.py)
=========================== short test summary info ============================
ERROR ../python_package/tests/test_galario.py
!!!!!!!!!!!!!!!!!!!! Interrupted: 1 error during collection !!!!!!!!!!!!!!!!!!!!
=============================== 1 error in 1.34s ===============================

67% tests passed, 1 tests failed out of 3


Label Time Summary:

pytest    =   2.49 secproc (1 test)

python    =   2.49 secproc (1 test)


Total Test time (real) =   2.49 sec


The following tests FAILED:

3 - galario (Failed)                                  pytest python

Errors while running CTest

make: *** [Makefile:71: test] Error 8

@Sigmanificient Sigmanificient mentioned this pull request Oct 19, 2025
Open
@vcunat vcunat added this pull request to the merge queue Oct 27, 2025
@vcunat
Copy link
Member

vcunat commented Oct 27, 2025

OK, why not. python312Packages.galario has been failing on Hydra for much longer than this, so let's not couple that failure with this fix.

Merged via the queue into NixOS:master with commit 0d68874 Oct 27, 2025
31 of 32 checks passed
@andrewzah andrewzah deleted the galario branch October 27, 2025 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@smaret smaret Awaiting requested review from smaret

Assignees

No one assigned

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@andrewzah @vcunat