Skip to content

nihstro: fix build with cmake4#453439

Merged
getchoo merged 1 commit intoNixOS:masterfrom
Sigmanificient:cmake4/nihstro
Oct 20, 2025
Merged

nihstro: fix build with cmake4#453439
getchoo merged 1 commit intoNixOS:masterfrom
Sigmanificient:cmake4/nihstro

Conversation

@Sigmanificient
Copy link
Member

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Oct 19, 2025
@nix-owners nix-owners bot requested a review from getchoo October 19, 2025 06:01
@iedame
Copy link
Contributor

iedame commented Oct 19, 2025

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 453439
Commit: 0e4cc17a363a4419cf9066c86af7cb7de916d2e2 (subsequent changes)
Merge: 2c319f6317d2fcf1032c9d0f52d582821ecd2766

Logs: https://github.com/iedame/nixpkgs-review-gha/actions/runs/18628367602


x86_64-linux

✅ 1 package built:
  • nihstro

aarch64-linux

✅ 1 package built:
  • nihstro

x86_64-darwin (sandbox = true)

✅ 1 package built:
  • nihstro

aarch64-darwin (sandbox = true)

✅ 1 package built:
  • nihstro

@nixpkgs-ci nixpkgs-ci bot added the 12.approvals: 1 This PR was reviewed and approved by one person. label Oct 19, 2025
Copy link
Member

@getchoo getchoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@getchoo getchoo added this pull request to the merge queue Oct 20, 2025
Merged via the queue into NixOS:master with commit b6e7cd0 Oct 20, 2025
32 of 35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants