Skip to content

nuked-md: fix build with cmake4#453435

Merged
OPNA2608 merged 1 commit intoNixOS:masterfrom
Sigmanificient:cmake4/nuked-md
Oct 19, 2025
Merged

nuked-md: fix build with cmake4#453435
OPNA2608 merged 1 commit intoNixOS:masterfrom
Sigmanificient:cmake4/nuked-md

Conversation

@Sigmanificient
Copy link
Member

@Sigmanificient Sigmanificient commented Oct 19, 2025

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@Sigmanificient Sigmanificient mentioned this pull request Oct 19, 2025
Open
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Oct 19, 2025
@nix-owners nix-owners bot requested a review from OPNA2608 October 19, 2025 05:40
@nixpkgs-ci nixpkgs-ci bot added 9.needs: reviewer This PR currently has no reviewers requested and needs attention. and removed 9.needs: reviewer This PR currently has no reviewers requested and needs attention. labels Oct 19, 2025
@iedame
Copy link
Contributor

iedame commented Oct 19, 2025

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 453435
Commit: 03795ff8c80ea8582eb3123fe3bb25a1d968222c (subsequent changes)
Merge: 45140a26709aab9d1b7bc6998350750e9aa2183d

Logs: https://github.com/iedame/nixpkgs-review-gha/actions/runs/18628373973

x86_64-linux

✅ 1 package built:
  • nuked-md

aarch64-linux

✅ 1 package built:
  • nuked-md

x86_64-darwin (sandbox = true)

✅ 1 package built:
  • nuked-md

aarch64-darwin (sandbox = true)

✅ 1 package built:
  • nuked-md

@nixpkgs-ci nixpkgs-ci bot added the 12.approvals: 1 This PR was reviewed and approved by one person. label Oct 19, 2025
OPNA2608
OPNA2608 approved these changes Oct 19, 2025
View reviewed changes
Copy link
Contributor

@OPNA2608 OPNA2608 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 453435
Commit: 03795ff8c80ea8582eb3123fe3bb25a1d968222c

x86_64-linux

✅ 2 packages built:
  • nixpkgs-manual
  • nuked-md
image

Looks okay to me. Please make sure to also submit this change to upstream!

@OPNA2608 OPNA2608 added 12.approvals: 2 This PR was reviewed and approved by two persons. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. and removed 12.approvals: 1 This PR was reviewed and approved by one person. labels Oct 19, 2025
@OPNA2608 OPNA2608 added this pull request to the merge queue Oct 19, 2025
Merged via the queue into NixOS:master with commit 3f62e27 Oct 19, 2025
34 of 38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@OPNA2608 OPNA2608 OPNA2608 approved these changes

+1 more reviewer

@iedame iedame iedame approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 12.approvals: 2 This PR was reviewed and approved by two persons. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Sigmanificient @iedame @OPNA2608