Skip to content

nxpmicro-mfgtools: fix build with cmake4#453403

Merged
Sigmanificient merged 1 commit intoNixOS:masterfrom
Sigmanificient:cmake4/nxpmicro-mfgtools
Oct 20, 2025
Merged

nxpmicro-mfgtools: fix build with cmake4#453403
Sigmanificient merged 1 commit intoNixOS:masterfrom
Sigmanificient:cmake4/nxpmicro-mfgtools

Conversation

@Sigmanificient
Copy link
Member

@Sigmanificient Sigmanificient commented Oct 19, 2025

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@Sigmanificient Sigmanificient mentioned this pull request Oct 19, 2025
Open
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Oct 19, 2025
@nix-owners nix-owners bot requested review from bmilanov and jraygauthier October 19, 2025 02:25
@Sigmanificient
Copy link
Member Author

Sigmanificient commented Oct 19, 2025

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 453403
Commit: cabad41370df43dcabf61fa6d2e8afd09de0695a (subsequent changes)
Merge: b2c13088b0de45ba66bd853923fbf2a878acc9fc

Logs: https://github.com/Sigmanificient/nixpkgs-review-gha/actions/runs/18624277822

x86_64-linux

✅ 1 package built:
  • nxpmicro-mfgtools

aarch64-linux

✅ 1 package built:
  • nxpmicro-mfgtools

x86_64-darwin (sandbox = true)

✅ 1 package built:
  • nxpmicro-mfgtools

aarch64-darwin (sandbox = true)

✅ 1 package built:
  • nxpmicro-mfgtools

@iedame
Copy link
Contributor

iedame commented Oct 19, 2025

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 453403
Commit: cabad41370df43dcabf61fa6d2e8afd09de0695a (subsequent changes)
Merge: 9181e1e44501135b85da9cf9665697c62c8c7fe5

Logs: https://github.com/iedame/nixpkgs-review-gha/actions/runs/18628416436

x86_64-linux

✅ 1 package built:
  • nxpmicro-mfgtools

aarch64-linux

✅ 1 package built:
  • nxpmicro-mfgtools

x86_64-darwin (sandbox = true)

✅ 1 package built:
  • nxpmicro-mfgtools

aarch64-darwin (sandbox = true)

✅ 1 package built:
  • nxpmicro-mfgtools

@nixpkgs-ci nixpkgs-ci bot added the 12.approvals: 1 This PR was reviewed and approved by one person. label Oct 19, 2025
@jraygauthier
Copy link
Member

jraygauthier commented Oct 20, 2025

LGTM although I wonder how:

-cmake_minimum_required(VERSION 3.4)
+cmake_minimum_required(VERSION 3.5)

would provide support for CMake V4.

Any idea @Sigmanificient ?

@iedame
Copy link
Contributor

iedame commented Oct 20, 2025

LGTM although I wonder how:

-cmake_minimum_required(VERSION 3.4)
+cmake_minimum_required(VERSION 3.5)

would provide support for CMake V4.

Any idea @Sigmanificient ?

I mean... If upstream is happy with bare minimum, who am I to complain.

@nixpkgs-ci nixpkgs-ci bot added 12.approvals: 2 This PR was reviewed and approved by two persons. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. and removed 12.approvals: 1 This PR was reviewed and approved by one person. labels Oct 20, 2025
@Sigmanificient
Copy link
Member Author

Sigmanificient commented Oct 20, 2025

Yes, sadly it wont keep them running for long ...

@Sigmanificient Sigmanificient added this pull request to the merge queue Oct 20, 2025
Merged via the queue into NixOS:master with commit 83945ad Oct 20, 2025
34 of 37 checks passed
@Sigmanificient Sigmanificient deleted the cmake4/nxpmicro-mfgtools branch October 20, 2025 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bmilanov bmilanov Awaiting requested review from bmilanov

2 more reviewers

@iedame iedame iedame approved these changes

@jraygauthier jraygauthier jraygauthier approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 12.approvals: 2 This PR was reviewed and approved by two persons. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Sigmanificient @iedame @jraygauthier