Skip to content

opentracing-cpp: drop#453386

Merged
wolfgangwalther merged 2 commits intoNixOS:masterfrom
Sigmanificient:cmake4/opentracing-cpp
Oct 23, 2025
Merged

opentracing-cpp: drop#453386
wolfgangwalther merged 2 commits intoNixOS:masterfrom
Sigmanificient:cmake4/opentracing-cpp

Conversation

@Sigmanificient
Copy link
Member

@Sigmanificient Sigmanificient commented Oct 19, 2025 •
edited
Loading

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@Sigmanificient Sigmanificient marked this pull request as draft October 19, 2025 01:06
@Sigmanificient Sigmanificient mentioned this pull request Oct 19, 2025
Open
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Oct 19, 2025
@Sigmanificient Sigmanificient marked this pull request as ready for review October 19, 2025 01:39
@nixpkgs-ci nixpkgs-ci bot added the 12.approvals: 1 This PR was reviewed and approved by one person. label Oct 19, 2025
@nixpkgs-ci nixpkgs-ci bot added 12.approvals: 2 This PR was reviewed and approved by two persons. and removed 12.approvals: 1 This PR was reviewed and approved by one person. labels Oct 19, 2025
@mdaniels5757 mdaniels5757 added the 8.has: clean-up This PR removes packages or removes other cruft label Oct 20, 2025
@nixpkgs-ci nixpkgs-ci bot added 12.approvals: 3+ This PR was reviewed and approved by three or more persons. and removed 12.approvals: 2 This PR was reviewed and approved by two persons. labels Oct 20, 2025
@wolfgangwalther wolfgangwalther added this pull request to the merge queue Oct 23, 2025
Merged via the queue into NixOS:master with commit a58ffa0 Oct 23, 2025
39 of 41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mdaniels5757 mdaniels5757 mdaniels5757 approved these changes

@leona-ya leona-ya leona-ya approved these changes

@RaitoBezarius RaitoBezarius Awaiting requested review from RaitoBezarius

@rbvermaa rbvermaa Awaiting requested review from rbvermaa

+1 more reviewer

@iedame iedame iedame approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

8.has: clean-up This PR removes packages or removes other cruft 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. 12.approvals: 3+ This PR was reviewed and approved by three or more persons.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Sigmanificient @iedame @mdaniels5757 @leona-ya @wolfgangwalther