Skip to content

kronometer: fix build with cmake4#453376

Merged
vcunat merged 1 commit intoNixOS:masterfrom
Sigmanificient:cmake4/kronometer
Oct 27, 2025
Merged

kronometer: fix build with cmake4#453376
vcunat merged 1 commit intoNixOS:masterfrom
Sigmanificient:cmake4/kronometer

Conversation

@Sigmanificient
Copy link
Member

@Sigmanificient Sigmanificient commented Oct 19, 2025 •
edited by dotlambda
Loading

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@Sigmanificient
Copy link
Member Author

Sigmanificient commented Oct 19, 2025

@eclairevoyant

@Sigmanificient Sigmanificient mentioned this pull request Oct 19, 2025
Open
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Oct 19, 2025
@eclairevoyant
Copy link
Contributor

eclairevoyant commented Oct 19, 2025

I created #453381 instead, since we can then use qt6 and don't have to carry patches

@dotlambda dotlambda mentioned this pull request Oct 19, 2025
Closed
13 tasks
@eclairevoyant
Copy link
Contributor

eclairevoyant commented Oct 23, 2025

Feel free to merge this.

@iedame
Copy link
Contributor

iedame commented Oct 26, 2025

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 453376
Commit: 023e7f419ba8343d54d1fdf65be482ead7febc1b (subsequent changes)
Merge: 6c01ea8a99b6e4c6fdb348228152df3f15381576

Logs: https://github.com/iedame/nixpkgs-review-gha/actions/runs/18816043105

x86_64-linux

✅ 1 package built:
  • kronometer

aarch64-linux

✅ 1 package built:
  • kronometer

x86_64-darwin

✅ No rebuilds

aarch64-darwin

✅ No rebuilds

iedame
iedame approved these changes Oct 26, 2025
View reviewed changes
Copy link
Contributor

@iedame iedame left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nixpkgs-ci nixpkgs-ci bot added the 12.approvals: 1 This PR was reviewed and approved by one person. label Oct 26, 2025
@nixpkgs-ci nixpkgs-ci bot added 12.approvals: 2 This PR was reviewed and approved by two persons. and removed 12.approvals: 1 This PR was reviewed and approved by one person. labels Oct 26, 2025
@vcunat vcunat added this pull request to the merge queue Oct 27, 2025
Merged via the queue into NixOS:master with commit ae57faf Oct 27, 2025
39 of 40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gepbird gepbird gepbird approved these changes

@peterhoeg peterhoeg Awaiting requested review from peterhoeg

+1 more reviewer

@iedame iedame iedame approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 12.approvals: 2 This PR was reviewed and approved by two persons.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Build failure: kronometer

5 participants

@Sigmanificient @eclairevoyant @iedame @gepbird @vcunat