Skip to content

canokey-usbip: fix build failure with cmake 4#453371

Merged
Sigmanificient merged 1 commit intoNixOS:masterfrom
drawbu:clement/push-rolnxptwrwtq
Oct 20, 2025
Merged

canokey-usbip: fix build failure with cmake 4#453371
Sigmanificient merged 1 commit intoNixOS:masterfrom
drawbu:clement/push-rolnxptwrwtq

Conversation

@drawbu
Copy link
Member

@drawbu drawbu commented Oct 19, 2025

Fix canokey-usbip build failure on newer cmake 4.

CMake 4 is no longer retro compatible with versions < 3.5

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Oct 19, 2025
@drawbu

This comment was marked as outdated.

@drawbu drawbu force-pushed the clement/push-rolnxptwrwtq branch 3 times, most recently from 26e8877 to 486d3ca Compare October 19, 2025 02:36
@drawbu
Copy link
Member Author

drawbu commented Oct 19, 2025

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 453371
Commit: 486d3ca6768575eb7c42b91936bd143356dea658 (subsequent changes)
Merge: c60654d848c5100fc692831cd82fbe041f1437c6

Logs: https://github.com/drawbu/nixpkgs-review-gha/actions/runs/18624257635


x86_64-linux

✅ 1 package built:
  • canokey-usbip

aarch64-linux

✅ 1 package built:
  • canokey-usbip

x86_64-darwin (sandbox = true)

✅ 1 package built:
  • canokey-usbip

aarch64-darwin (sandbox = true)

✅ 1 package built:
  • canokey-usbip

@drawbu drawbu marked this pull request as ready for review October 19, 2025 02:48
@nix-owners nix-owners bot requested a review from jmbaur October 19, 2025 02:49
@nixpkgs-ci nixpkgs-ci bot added 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. labels Oct 19, 2025
- CMake 4 is no longer retro compatible with versions < 3.5
@drawbu drawbu force-pushed the clement/push-rolnxptwrwtq branch from 486d3ca to 6ba62bc Compare October 19, 2025 06:02
@Sigmanificient Sigmanificient added this pull request to the merge queue Oct 20, 2025
Merged via the queue into NixOS:master with commit 3d33d9c Oct 20, 2025
28 of 31 checks passed
@drawbu drawbu deleted the clement/push-rolnxptwrwtq branch October 20, 2025 05:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants