Skip to content

bio-gappa: fix build failure with cmake 4#453364

Merged
Sigmanificient merged 1 commit intoNixOS:masterfrom
drawbu:clement/push-nvuwmsyntrzq
Oct 22, 2025
Merged

bio-gappa: fix build failure with cmake 4#453364
Sigmanificient merged 1 commit intoNixOS:masterfrom
drawbu:clement/push-nvuwmsyntrzq

Conversation

@drawbu
Copy link
Member

@drawbu drawbu commented Oct 18, 2025 •
edited
Loading

Fix bio-gappa build failure on newer cmake 4.

CMake 4 is no longer retro compatible with versions < 3.5

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@drawbu
bio-gappa: fix build failure with cmake 4
704a1c0 
- CMake 4 is no longer retro compatible with versions < 3.5
@Sigmanificient Sigmanificient mentioned this pull request Oct 18, 2025
Open
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Oct 18, 2025
@drawbu
Copy link
Member Author

drawbu commented Oct 19, 2025

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 453364
Commit: 704a1c0564125a2415f9a0902f3f8954d5fcae50 (subsequent changes)
Merge: c2106908af3066c7810069fa795546a9012a1251

Logs: https://github.com/drawbu/nixpkgs-review-gha/actions/runs/18622584552

x86_64-linux

✅ 1 package built:
  • bio-gappa

aarch64-linux

✅ 1 package built:
  • bio-gappa

x86_64-darwin (sandbox = true)

✅ 1 package built:
  • bio-gappa

aarch64-darwin (sandbox = true)

✅ 1 package built:
  • bio-gappa

@drawbu drawbu marked this pull request as ready for review October 19, 2025 00:09
@nix-owners nix-owners bot requested a review from bzizou October 19, 2025 00:10
bzizou
bzizou approved these changes Oct 21, 2025
View reviewed changes
Copy link
Contributor

@bzizou bzizou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as it builds

@nixpkgs-ci nixpkgs-ci bot added 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. labels Oct 21, 2025
@Sigmanificient Sigmanificient added this pull request to the merge queue Oct 22, 2025
Merged via the queue into NixOS:master with commit 079e4cb Oct 22, 2025
38 of 41 checks passed
@drawbu drawbu deleted the clement/push-nvuwmsyntrzq branch October 23, 2025 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@bzizou bzizou bzizou approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@drawbu @bzizou @Sigmanificient