Skip to content

uri: fix build failure with cmake 4#453361

Merged
jopejoe1 merged 1 commit intoNixOS:masterfrom
drawbu:clement/push-mrkwwusukppk
Oct 21, 2025
Merged

uri: fix build failure with cmake 4#453361
jopejoe1 merged 1 commit intoNixOS:masterfrom
drawbu:clement/push-mrkwwusukppk

Conversation

@drawbu
Copy link
Member

@drawbu drawbu commented Oct 18, 2025 •
edited
Loading

Fix uri build failure on newer cmake 4.

CMake 4 is no longer retro compatible with versions < 3.5

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@drawbu
uri: fix build failure with cmake 4
8c20972 
- CMake 4 is no longer retro compatible with versions < 3.5
@Sigmanificient Sigmanificient mentioned this pull request Oct 18, 2025
Open
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Oct 18, 2025
@drawbu
Copy link
Member Author

drawbu commented Oct 18, 2025

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 453361
Commit: 8c20972bbdcb001b37d34d21c7c68fc00a33adb6 (subsequent changes)
Merge: 0d213b51c9a1c1b5380f2fc5094520c7119fb7d8

Logs: https://github.com/drawbu/nixpkgs-review-gha/actions/runs/18622458049

x86_64-linux

✅ 1 package built:
  • uri

aarch64-linux

✅ 1 package built:
  • uri

x86_64-darwin (sandbox = true)

✅ 1 package built:
  • uri

aarch64-darwin (sandbox = true)

✅ 1 package built:
  • uri

@drawbu drawbu marked this pull request as ready for review October 18, 2025 23:47
@nixpkgs-ci nixpkgs-ci bot added the 9.needs: reviewer This PR currently has no reviewers requested and needs attention. label Oct 18, 2025
@jopejoe1 jopejoe1 added this pull request to the merge queue Oct 21, 2025
Merged via the queue into NixOS:master with commit fd10f39 Oct 21, 2025
36 of 39 checks passed
@nixpkgs-ci nixpkgs-ci bot added 12.approvals: 1 This PR was reviewed and approved by one person. and removed 9.needs: reviewer This PR currently has no reviewers requested and needs attention. labels Oct 21, 2025
@drawbu drawbu deleted the clement/push-mrkwwusukppk branch October 21, 2025 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jopejoe1 jopejoe1 jopejoe1 approved these changes

Assignees

No one assigned

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@drawbu @jopejoe1