Skip to content

cpp-netlib: fix build failure with cmake 4#453360

Merged
Sigmanificient merged 1 commit intoNixOS:masterfrom
drawbu:clement/push-tswwmykvytyp
Oct 20, 2025
Merged

cpp-netlib: fix build failure with cmake 4#453360
Sigmanificient merged 1 commit intoNixOS:masterfrom
drawbu:clement/push-tswwmykvytyp

Conversation

@drawbu
Copy link
Member

@drawbu drawbu commented Oct 18, 2025 •
edited
Loading

Fix cpp-netlib build failure on newer cmake 4.

CMake 4 is no longer retro compatible with versions < 3.5

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@drawbu
cpp-netlib: fix build failure with cmake 4
1b7a46c 
- CMake 4 is no longer retro compatible with versions < 3.5
@Sigmanificient Sigmanificient mentioned this pull request Oct 18, 2025
Open
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Oct 18, 2025
@drawbu
Copy link
Member Author

drawbu commented Oct 18, 2025

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 453360
Commit: 1b7a46c24ed506533e29c20ac579bb57892e2bff (subsequent changes)
Merge: d4335cf569ede4669a2993fe76082dc1edfaad7a

Logs: https://github.com/drawbu/nixpkgs-review-gha/actions/runs/18622456331

x86_64-linux

✅ 1 package built:
  • cpp-netlib

aarch64-linux

✅ 1 package built:
  • cpp-netlib

x86_64-darwin (sandbox = true)

✅ 1 package built:
  • cpp-netlib

aarch64-darwin (sandbox = true)

✅ 1 package built:
  • cpp-netlib

@drawbu drawbu marked this pull request as ready for review October 18, 2025 23:44
@nixpkgs-ci nixpkgs-ci bot added the 9.needs: reviewer This PR currently has no reviewers requested and needs attention. label Oct 18, 2025
@Sigmanificient Sigmanificient added this pull request to the merge queue Oct 20, 2025
Merged via the queue into NixOS:master with commit 773d463 Oct 20, 2025
35 of 38 checks passed
@drawbu drawbu deleted the clement/push-tswwmykvytyp branch October 20, 2025 05:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

9.needs: reviewer This PR currently has no reviewers requested and needs attention. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@drawbu @Sigmanificient