Skip to content

cppcodec, nitrokey-app: fix build failure with cmake 4#453359

Merged
vcunat merged 2 commits intoNixOS:masterfrom
drawbu:clement/push-spxknyuowzvr
Oct 27, 2025
Merged

cppcodec, nitrokey-app: fix build failure with cmake 4#453359
vcunat merged 2 commits intoNixOS:masterfrom
drawbu:clement/push-spxknyuowzvr

Conversation

@drawbu
Copy link
Member

@drawbu drawbu commented Oct 18, 2025 •
edited
Loading

Fix cppcodec & nitrokey-app (which depends on it) build failure on newer cmake 4.

CMake 4 is no longer retro compatible with versions < 3.5

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. labels Oct 18, 2025
@Sigmanificient Sigmanificient mentioned this pull request Oct 18, 2025
Open
@drawbu
Copy link
Member Author

drawbu commented Oct 19, 2025

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 453359
Commit: 4e188dedf9f48b6d0bbcc34ae9a066b25d980295 (subsequent changes)
Merge: 30f75789d287ad45bccd63a4232bb701cbb291de

Logs: https://github.com/drawbu/nixpkgs-review-gha/actions/runs/18623002540

x86_64-linux

✅ 2 packages built:
  • cppcodec
  • nitrokey-app

aarch64-linux

✅ 2 packages built:
  • cppcodec
  • nitrokey-app

x86_64-darwin (sandbox = relaxed)

✅ 2 packages built:
  • cppcodec
  • nitrokey-app

aarch64-darwin (sandbox = relaxed)

✅ 2 packages built:
  • cppcodec
  • nitrokey-app

@drawbu drawbu marked this pull request as ready for review October 19, 2025 00:44
dotlambda
dotlambda reviewed Oct 19, 2025
View reviewed changes
drawbu added 2 commits October 18, 2025 22:52
@drawbu
cppcodec: fix build failure with cmake 4
649e76f 
- CMake 4 is no longer retro compatible with versions < 3.5
@drawbu
nitrokey-app: fix build failure with cmake 4
c5c6917 
- CMake 4 is no longer retro compatible with versions < 3.5
@drawbu drawbu force-pushed the clement/push-spxknyuowzvr branch from 4e188de to c5c6917 Compare October 19, 2025 05:52
panicgh
panicgh approved these changes Oct 23, 2025
View reviewed changes
Copy link
Contributor

@panicgh panicgh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fixes!

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 453359
Commit: c5c6917336ff7830b708ac52b67a04b494a7aeca

x86_64-linux

✅ 2 packages built:
  • cppcodec
  • nitrokey-app

@nixpkgs-ci nixpkgs-ci bot added 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. labels Oct 23, 2025
@iedame
Copy link
Contributor

iedame commented Oct 26, 2025

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 453359
Commit: c5c6917336ff7830b708ac52b67a04b494a7aeca (subsequent changes)
Merge: 4a417da13352593b27ab0abb25d6668db558ee26

Logs: https://github.com/iedame/nixpkgs-review-gha/actions/runs/18825487186

x86_64-linux

✅ 2 packages built:
  • cppcodec
  • nitrokey-app

aarch64-linux

✅ 2 packages built:
  • cppcodec
  • nitrokey-app

x86_64-darwin (sandbox = true)

❌ 1 package failed to build:
  • nitrokey-app
✅ 1 package built:
  • cppcodec

aarch64-darwin (sandbox = true)

❌ 1 package failed to build:
  • nitrokey-app
✅ 1 package built:
  • cppcodec

@iedame
Copy link
Contributor

iedame commented Oct 27, 2025

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 453359
Commit: c5c6917336ff7830b708ac52b67a04b494a7aeca (subsequent changes)
Merge: d7c067ad67409f4013a19e6f723917a52d9b2612

Logs: https://github.com/iedame/nixpkgs-review-gha/actions/runs/18825786468

x86_64-darwin (sandbox = false)

✅ 2 packages built:
  • cppcodec
  • nitrokey-app

aarch64-darwin (sandbox = false)

✅ 2 packages built:
  • cppcodec
  • nitrokey-app

vcunat
vcunat reviewed Oct 27, 2025
View reviewed changes
pkgs/by-name/cp/cppcodec/package.nix
hash = "sha256-0MCx3nTsey4Qonx+lyexbcxut0qIHOJZbkJ9u23Zuv8=";
})
];

Copy link
Member

@vcunat vcunat Oct 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's perhaps a bit annoying that this patch also updates the version of the project. But given that the change is from 0.1 to 0.3 and we're on 0.2, it won't be a new breakage.

@vcunat vcunat added this pull request to the merge queue Oct 27, 2025
Merged via the queue into NixOS:master with commit ebb4f03 Oct 27, 2025
31 of 32 checks passed
@drawbu drawbu deleted the clement/push-spxknyuowzvr branch October 28, 2025 04:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vcunat vcunat vcunat left review comments

@KaiHa KaiHa Awaiting requested review from KaiHa

@RaitoBezarius RaitoBezarius Awaiting requested review from RaitoBezarius

@dotlambda dotlambda Awaiting requested review from dotlambda

+1 more reviewer

@panicgh panicgh panicgh approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@drawbu @iedame @vcunat @dotlambda @panicgh