Skip to content

cpp-redis: fix build with cmake 4#453353

Merged
Sigmanificient merged 1 commit intoNixOS:masterfrom
drawbu:clement/push-xsnzxsyklsru
Oct 23, 2025
Merged

cpp-redis: fix build with cmake 4#453353
Sigmanificient merged 1 commit intoNixOS:masterfrom
drawbu:clement/push-xsnzxsyklsru

Conversation

@drawbu
Copy link
Member

@drawbu drawbu commented Oct 18, 2025

Fix avidemux build failure on newer cmake 4.

CMake 4 is no longer retro compatible with versions < 3.5

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@drawbu
cpp-redis: fix build failure with cmake 4
9b7a288 
- CMake 4 is no longer retro compatible with versions < 3.5
@drawbu drawbu force-pushed the clement/push-xsnzxsyklsru branch from 7e362ca to 9b7a288 Compare October 18, 2025 22:56
@drawbu drawbu changed the title Clement/push xsnzxsyklsru cpp-redis: fix build with cmake 4 Oct 18, 2025
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Oct 18, 2025
@Sigmanificient Sigmanificient mentioned this pull request Oct 18, 2025
Open
@drawbu
Copy link
Member Author

drawbu commented Oct 18, 2025

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 453353
Commit: 9b7a288947451982c405279f0a78474cc5cc85ce (subsequent changes)
Merge: 974409f9c8c97f15c77036ca81a75d32a667004e

Logs: https://github.com/drawbu/nixpkgs-review-gha/actions/runs/18622295143

x86_64-linux

✅ 1 package built:
  • cpp-redis

aarch64-linux

✅ 1 package built:
  • cpp-redis

x86_64-darwin (sandbox = true)

✅ 1 package built:
  • cpp-redis

aarch64-darwin (sandbox = true)

✅ 1 package built:
  • cpp-redis

@drawbu drawbu marked this pull request as ready for review October 18, 2025 23:34
@nix-owners nix-owners bot requested a review from poelzi October 18, 2025 23:35
@nixpkgs-ci nixpkgs-ci bot added the 12.approvals: 1 This PR was reviewed and approved by one person. label Oct 22, 2025
@Sigmanificient Sigmanificient added this pull request to the merge queue Oct 23, 2025
Merged via the queue into NixOS:master with commit a688ac7 Oct 23, 2025
35 of 37 checks passed
@drawbu drawbu deleted the clement/push-xsnzxsyklsru branch October 23, 2025 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@poelzi poelzi Awaiting requested review from poelzi

1 more reviewer

@ethancedwards8 ethancedwards8 ethancedwards8 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@drawbu @ethancedwards8 @Sigmanificient