Skip to content

performous: fix build with cmake 4#453189

Merged
wegank merged 1 commit intoNixOS:masterfrom
wegank:performous-fix
Oct 19, 2025
Merged

performous: fix build with cmake 4#453189
wegank merged 1 commit intoNixOS:masterfrom
wegank:performous-fix

Conversation

@wegank
Copy link
Member

@wegank wegank commented Oct 18, 2025 •
edited
Loading

#445447

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@wegank wegank mentioned this pull request Oct 18, 2025
Open
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 9.needs: reviewer This PR currently has no reviewers requested and needs attention. labels Oct 18, 2025
@Sigmanificient
Copy link
Member

Sigmanificient commented Oct 18, 2025

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 453189
Commit: 85dcda7aa60b00c607f0d55e47d79c4955cdab8e (subsequent changes)
Merge: 6d69bdd4289d9b4f9094c0d9e42c961a59c55cc1

Logs: https://github.com/Sigmanificient/nixpkgs-review-gha/actions/runs/18619616666

x86_64-linux

✅ 1 package built:
  • performous

aarch64-linux

✅ 1 package built:
  • performous

@Sigmanificient
Copy link
Member

Sigmanificient commented Oct 18, 2025

Could we apply this patch instead? (to ced-src)

(fetchpatch {
  url = "https://github.com/performous/compact_enc_det/commit/28f46c18c60b851773b0ff61f3ce416fb09adcf3.patch?full_index=1";
  hash = "sha256-7R4+hPxxJwkUQsa1W81Vx2s88U9NG6UW/ZVvYpe2zDA=";
})

@Sigmanificient
Copy link
Member

Sigmanificient commented Oct 18, 2025

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 453189
Commit: 9246d9ba335811d233241e90defd01c988e414b8 (subsequent changes)
Merge: a7dfd6e3bae0fa70cc3924e1530f121414301ea2

Logs: https://github.com/Sigmanificient/nixpkgs-review-gha/actions/runs/18622284164

x86_64-linux

✅ 1 package built:
  • performous

aarch64-linux

✅ 1 package built:
  • performous

x86_64-darwin

✅ No rebuilds

aarch64-darwin

✅ No rebuilds

@nixpkgs-ci nixpkgs-ci bot added 12.approvals: 1 This PR was reviewed and approved by one person. and removed 9.needs: reviewer This PR currently has no reviewers requested and needs attention. labels Oct 18, 2025
@wegank wegank added this pull request to the merge queue Oct 19, 2025
Merged via the queue into NixOS:master with commit 3afacfc Oct 19, 2025
28 of 31 checks passed
@wegank wegank deleted the performous-fix branch October 19, 2025 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Sigmanificient Sigmanificient Sigmanificient approved these changes

Assignees

No one assigned

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@wegank @Sigmanificient