Skip to content

fatcat: fix build with cmake-4#453161

Merged
Sigmanificient merged 1 commit intoNixOS:masterfrom
andrewzah:fatcat
Oct 20, 2025
Merged

fatcat: fix build with cmake-4#453161
Sigmanificient merged 1 commit intoNixOS:masterfrom
andrewzah:fatcat

Conversation

@andrewzah
Copy link
Contributor

@andrewzah andrewzah commented Oct 18, 2025

Fixes build issue related to cmake 4, noted in #445447.

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Oct 18, 2025
@nix-owners nix-owners bot requested a review from Cynerd October 18, 2025 08:50
@Sigmanificient Sigmanificient mentioned this pull request Oct 18, 2025
Open
@andrewzah
Copy link
Contributor Author

andrewzah commented Oct 18, 2025

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 453161
Commit: 6209b29070531627e4c822d565a0e3779432e838 (subsequent changes)
Merge: dacba32d1716700dd6717845de16ff1b24823576

Logs: https://github.com/andrewzah/nixpkgs-review-gha/actions/runs/18617780942

x86_64-linux

✅ 1 package built:
  • fatcat

aarch64-linux

✅ 1 package built:
  • fatcat

x86_64-darwin (sandbox = true)

❌ 1 package failed to build:
  • fatcat
Error logs: `x86_64-darwin`
fatcat 
/nix/build/nix-6123-3169850411/source/src/FatUtils.h:35:55: error: use of undeclared identifier 'ptr_fun'
   35 |   s.erase(s.begin(), find_if(s.begin(), s.end(), not1(ptr_fun<int, int>(isspace))));
      |                                                       ^~~~~~~
/nix/build/nix-6123-3169850411/source/src/FatUtils.h:41:46: error: use of undeclared identifier 'ptr_fun'
   41 |   s.erase(find_if(s.rbegin(), s.rend(), not1(ptr_fun<int, int>(isspace))).base(), s.end());
      |                                              ^~~~~~~
In file included from /nix/build/nix-6123-3169850411/source/src/core/FatEntry.cpp:7:
/nix/build/nix-6123-3169850411/source/src/FatUtils.h:35:55: error: use of undeclared identifier 'ptr_fun'
   35 |   s.erase(s.begin(), find_if(s.begin(), s.end(), not1(ptr_fun<int, int>(isspace))));
      |                                                       ^~~~~~~
/nix/build/nix-6123-3169850411/source/src/FatUtils.h:41:46: error: use of undeclared identifier 'ptr_fun'
   41 |   s.erase(find_if(s.rbegin(), s.rend(), not1(ptr_fun<int, int>(isspace))).base(), s.end());
      |                                              ^~~~~~~
2 errors generated.
make[2]: *** [CMakeFiles/fatcat.dir/build.make:93: CMakeFiles/fatcat.dir/src/core/FatEntry.cpp.o] Error 1
make[2]: *** Waiting for unfinished jobs....
2 errors generated.
make[2]: *** [CMakeFiles/fatcat.dir/build.make:79: CMakeFiles/fatcat.dir/src/fatcat.cpp.o] Error 1
make[1]: *** [CMakeFiles/Makefile2:87: CMakeFiles/fatcat.dir/all] Error 2
make: *** [Makefile:136: all] Error 2

aarch64-darwin (sandbox = true)

❌ 1 package failed to build:
  • fatcat
Error logs: `aarch64-darwin`
fatcat 
/nix/build/nix-25920-3477190564/source/src/FatUtils.h:35:55: error: use of undeclared identifier 'ptr_fun'
   35 |   s.erase(s.begin(), find_if(s.begin(), s.end(), not1(ptr_fun<int, int>(isspace))));
      |                                                       ^~~~~~~
/nix/build/nix-25920-3477190564/source/src/FatUtils.h:41:46: error: use of undeclared identifier 'ptr_fun'
   41 |   s.erase(find_if(s.rbegin(), s.rend(), not1(ptr_fun<int, int>(isspace))).base(), s.end());
      |                                              ^~~~~~~
In file included from /nix/build/nix-25920-3477190564/source/src/core/FatEntry.cpp:7:
/nix/build/nix-25920-3477190564/source/src/FatUtils.h:35:55: error: use of undeclared identifier 'ptr_fun'
   35 |   s.erase(s.begin(), find_if(s.begin(), s.end(), not1(ptr_fun<int, int>(isspace))));
      |                                                       ^~~~~~~
/nix/build/nix-25920-3477190564/source/src/FatUtils.h:41:46: error: use of undeclared identifier 'ptr_fun'
   41 |   s.erase(find_if(s.rbegin(), s.rend(), not1(ptr_fun<int, int>(isspace))).base(), s.end());
      |                                              ^~~~~~~
2 errors generated.
make[2]: *** [CMakeFiles/fatcat.dir/build.make:93: CMakeFiles/fatcat.dir/src/core/FatEntry.cpp.o] Error 1
make[2]: *** Waiting for unfinished jobs....
2 errors generated.
make[2]: *** [CMakeFiles/fatcat.dir/build.make:79: CMakeFiles/fatcat.dir/src/fatcat.cpp.o] Error 1
make[1]: *** [CMakeFiles/Makefile2:87: CMakeFiles/fatcat.dir/all] Error 2
make: *** [Makefile:136: all] Error 2

Cynerd
Cynerd approved these changes Oct 20, 2025
View reviewed changes
Copy link
Contributor

@Cynerd Cynerd left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thank you for covering this.

@NixOS/nixpkgs-merge-bot merge

@nixpkgs-merge-bot
Copy link
Contributor

nixpkgs-merge-bot bot commented Oct 20, 2025

@Cynerd merge not permitted (#305350):
CommitterPR: pr author is not committer
R-Ryantm Maintainer merge: pr author is not r-ryantm

@nixpkgs-ci nixpkgs-ci bot added 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. labels Oct 20, 2025
@Sigmanificient Sigmanificient added this pull request to the merge queue Oct 20, 2025
Merged via the queue into NixOS:master with commit ee15a97 Oct 20, 2025
34 of 36 checks passed
@andrewzah andrewzah deleted the fatcat branch October 20, 2025 23:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@Cynerd Cynerd Cynerd approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@andrewzah @Cynerd @Sigmanificient