Skip to content

shark: fix build with cmake-4#453157

Merged
GaetanLepage merged 1 commit intoNixOS:masterfrom
andrewzah:shark
Oct 19, 2025
Merged

shark: fix build with cmake-4#453157
GaetanLepage merged 1 commit intoNixOS:masterfrom
andrewzah:shark

Conversation

@andrewzah
Copy link
Contributor

Fixes build issue with cmake 4, noted in #445447.

Tagging @daspk04.

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. labels Oct 18, 2025
@nix-owners nix-owners bot requested a review from daspk04 October 18, 2025 08:23
@andrewzah
Copy link
Contributor Author

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 453157
Commit: 2c3348d7f44875b7e06032651ea575806745d044 (subsequent changes)
Merge: ab4b3a48d4e5e8f610d5a0e13ca1c6bac1a4d1d4

Logs: https://github.com/andrewzah/nixpkgs-review-gha/actions/runs/18617777377


x86_64-linux

❌ 5 packages failed to build:
  • otb
  • python312Packages.pyotb
  • python312Packages.pyotb.dist
  • python313Packages.pyotb
  • python313Packages.pyotb.dist
✅ 1 package built:
  • shark

aarch64-linux

❌ 5 packages failed to build:
  • otb
  • python312Packages.pyotb
  • python312Packages.pyotb.dist
  • python313Packages.pyotb
  • python313Packages.pyotb.dist
✅ 1 package built:
  • shark

x86_64-darwin (sandbox = true)

✅ 1 package built:
  • shark

aarch64-darwin (sandbox = true)

✅ 1 package built:
  • shark

@Sigmanificient
Copy link
Member

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 453157
Commit: 2c3348d7f44875b7e06032651ea575806745d044 (subsequent changes)
Merge: c165b36afd53d120045c434bc3e594019b17f71f

Logs: https://github.com/Sigmanificient/nixpkgs-review-gha/actions/runs/18619617791


x86_64-linux

❌ 5 packages failed to build:
  • otb
  • python312Packages.pyotb
  • python312Packages.pyotb.dist
  • python313Packages.pyotb
  • python313Packages.pyotb.dist
✅ 1 package built:
  • shark

aarch64-linux

❌ 5 packages failed to build:
  • otb
  • python312Packages.pyotb
  • python312Packages.pyotb.dist
  • python313Packages.pyotb
  • python313Packages.pyotb.dist
✅ 1 package built:
  • shark

x86_64-darwin (sandbox = true)

✅ 1 package built:
  • shark

aarch64-darwin (sandbox = true)

✅ 1 package built:
  • shark

@daspk04
Copy link
Contributor

daspk04 commented Oct 19, 2025

Thanks @andrewzah !

I will fix the otb related issues in a separate MR.

@nixpkgs-ci nixpkgs-ci bot added 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. labels Oct 19, 2025
@GaetanLepage GaetanLepage added this pull request to the merge queue Oct 19, 2025
Merged via the queue into NixOS:master with commit 4439064 Oct 19, 2025
33 of 35 checks passed
@andrewzah andrewzah deleted the shark branch October 19, 2025 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants