Skip to content

openambit: fix build with cmake-4#453154

Merged
Sigmanificient merged 1 commit intoNixOS:masterfrom
andrewzah:openambit
Oct 26, 2025
Merged

openambit: fix build with cmake-4#453154
Sigmanificient merged 1 commit intoNixOS:masterfrom
andrewzah:openambit

Conversation

@andrewzah
Copy link
Contributor

Fixes build issue with cmake 4 noted in #445447.

Tagging @rycee.

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Oct 18, 2025
@nix-owners nix-owners bot requested a review from rycee October 18, 2025 08:13
@andrewzah
Copy link
Contributor Author

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 453154
Commit: fa311c7bb99ad70525f2a9c31bd3bddbad57b286 (subsequent changes)
Merge: 5f50558d1c843511e13b1840f7975d9b39647b6b

Logs: https://github.com/andrewzah/nixpkgs-review-gha/actions/runs/18617773375


x86_64-linux

✅ 1 package built:
  • openambit

aarch64-linux

✅ 1 package built:
  • openambit

x86_64-darwin

No rebuilds


aarch64-darwin

No rebuilds

@nixpkgs-ci nixpkgs-ci bot added the 12.approvals: 1 This PR was reviewed and approved by one person. label Oct 23, 2025
@Sigmanificient Sigmanificient added this pull request to the merge queue Oct 26, 2025
Merged via the queue into NixOS:master with commit 4b676b3 Oct 26, 2025
33 of 34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants