Skip to content

zsync2: 2.0.0-alpha-1-20230304 -> 2.0.0-alpha-1-20250926#453150

Merged
JohnRTitor merged 1 commit intoNixOS:masterfrom
andrewzah:zsync2
Oct 25, 2025
Merged

zsync2: 2.0.0-alpha-1-20230304 -> 2.0.0-alpha-1-20250926#453150
JohnRTitor merged 1 commit intoNixOS:masterfrom
andrewzah:zsync2

Conversation

@andrewzah
Copy link
Contributor

@andrewzah andrewzah commented Oct 18, 2025

This update also fixes the cmake 4 issue outlined in #445447.

Tagging @Aleksanaa.

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@andrewzah
zsync2: 2.0.0-alpha-1-20230304 -> 2.0.0-alpha-1-20250926
75de7cb 
* This update also fixes the cmake 4 issue outlined in
  NixOS#445447.
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. labels Oct 18, 2025
@nix-owners nix-owners bot requested a review from Aleksanaa October 18, 2025 07:57
@andrewzah
Copy link
Contributor Author

andrewzah commented Oct 18, 2025

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 453150
Commit: 75de7cb4cfbbf1c5d7a9e2f808e3b68116bd73f2 (subsequent changes)
Merge: 186c559d0d3739fc78304fda354fabdd670c5473

Logs: https://github.com/andrewzah/nixpkgs-review-gha/actions/runs/18617771738

x86_64-linux

❌ 2 packages failed to build:
  • appimageupdate
  • appimageupdate-qt
✅ 1 package built:
  • zsync2

aarch64-linux

❌ 2 packages failed to build:
  • appimageupdate
  • appimageupdate-qt
✅ 1 package built:
  • zsync2

x86_64-darwin

✅ No rebuilds

aarch64-darwin

✅ No rebuilds

@Sigmanificient Sigmanificient mentioned this pull request Oct 18, 2025
Open
@iedame
Copy link
Contributor

iedame commented Oct 24, 2025

Looks like appimageupdate is failing due to argagg and itself (I tested with argagg fix and zsync2 update and it still failed):

argagg> CMake Error at CMakeLists.txt:1 (cmake_minimum_required):
argagg>   Compatibility with CMake < 3.5 has been removed from CMake.
argagg> 
argagg>   Update the VERSION argument <min> value.  Or, use the <min>...<max> syntax
argagg>   to tell CMake that the project requires at least <min> but has been updated
argagg>   to work with policies introduced by <max> or earlier.
argagg> 
argagg>   Or, add -DCMAKE_POLICY_VERSION_MINIMUM=3.5 to try configuring anyway.
argagg> 
argagg> 
argagg> -- Configuring incomplete, errors occurred!
copying path '/nix/store/1d8pl2r39a7f2j2dmg5x08jidnky9qgl-qtwayland-5.15.17-dev' from 'https://cache.nixos.org/'...
error: Cannot build '/nix/store/cxvarg1lv2q010qhvz053168lrw74pwv-argagg-0.4.7.drv'.
       Reason: builder failed with exit code 1.
       Output paths:
         /nix/store/4dwda6c7l5s4pqhsi6v2bm9cw0xk1vaq-argagg-0.4.7

So this should fix argagg: #455090 and here appimageupdate/appimageupdate-qt: #455099
I tested the four packages together and everything build correctly and basic usage seems fine, but please give it a try if possible.

iedame

This comment was marked as outdated.

Sign in to view

@nixpkgs-ci nixpkgs-ci bot added the 12.approvals: 1 This PR was reviewed and approved by one person. label Oct 24, 2025
@iedame iedame self-requested a review October 24, 2025 02:33
@iedame
Copy link
Contributor

iedame commented Oct 24, 2025

Should we include argagg, zsync2 and appimageupdate into the same PR? nixpkgs-review haves a hard time with separate PRs. Testing manually worked.

@iedame iedame mentioned this pull request Oct 24, 2025
Merged
13 tasks
@JohnRTitor JohnRTitor added this pull request to the merge queue Oct 25, 2025
Merged via the queue into NixOS:master with commit 699518a Oct 25, 2025
31 of 33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JohnRTitor JohnRTitor JohnRTitor approved these changes

@Aleksanaa Aleksanaa Awaiting requested review from Aleksanaa

@iedame iedame Awaiting requested review from iedame

Assignees

No one assigned

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@andrewzah @iedame @JohnRTitor