Skip to content

vangers: fix cmake 4 build, modernize#453122

Merged
Sigmanificient merged 2 commits intoNixOS:masterfrom
ethancedwards8:vangers-cmake
Oct 23, 2025
Merged

vangers: fix cmake 4 build, modernize#453122
Sigmanificient merged 2 commits intoNixOS:masterfrom
ethancedwards8:vangers-cmake

Conversation

@ethancedwards8
Copy link
Member

@ethancedwards8 ethancedwards8 commented Oct 18, 2025 •
edited by Sigmanificient
Loading

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Oct 18, 2025
@ethancedwards8
vangers: fix build for cmake 4
00d247d 
Signed-off-by: Ethan Carter Edwards <[email protected]>
@ethancedwards8
vangers: modernize
9b4585d 
Signed-off-by: Ethan Carter Edwards <[email protected]>
@ethancedwards8 ethancedwards8 changed the title Vangers cmake vangers: fix cmake 4 build, modernize Oct 18, 2025
@Sigmanificient
Copy link
Member

Sigmanificient commented Oct 18, 2025

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 453122
Commit: 9b4585dea5e5d96fb818bb3f3caec24033e9c0db (subsequent changes)
Merge: 8c65ac17add4f65aecb5020648d0a12a395cca1c

Logs: https://github.com/Sigmanificient/nixpkgs-review-gha/actions/runs/18619619889

x86_64-linux

✅ 1 package built:
  • vangers

aarch64-linux

✅ 1 package built:
  • vangers

x86_64-darwin (sandbox = true)

✅ 1 package built:
  • vangers

aarch64-darwin (sandbox = true)

✅ 1 package built:
  • vangers

@Sigmanificient Sigmanificient mentioned this pull request Oct 18, 2025
Open
@nixpkgs-ci nixpkgs-ci bot added 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. labels Oct 20, 2025
@Sigmanificient Sigmanificient added this pull request to the merge queue Oct 23, 2025
Merged via the queue into NixOS:master with commit e27456a Oct 23, 2025
32 of 34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SuperSandro2000 SuperSandro2000 Awaiting requested review from SuperSandro2000

1 more reviewer

@3JlOy-PYCCKUi 3JlOy-PYCCKUi 3JlOy-PYCCKUi approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ethancedwards8 @Sigmanificient @3JlOy-PYCCKUi