Skip to content

QuadProgpp: fix cmake-4 build#453042

Merged
wegank merged 1 commit intoNixOS:masterfrom
trofi:QuadProgpp-cmake-4-fix
Oct 17, 2025
Merged

QuadProgpp: fix cmake-4 build#453042
wegank merged 1 commit intoNixOS:masterfrom
trofi:QuadProgpp-cmake-4-fix

Conversation

@trofi
Copy link
Contributor

@trofi trofi commented Oct 17, 2025

Without the change the build on cmake-4 fails as
https://hydra.nixos.org/build/308951858:

CMake Error at CMakeLists.txt:1 (cmake_minimum_required):
  Compatibility with CMake < 3.5 has been removed from CMake.

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

Without the change the build on cmake-4 fails as
https://hydra.nixos.org/build/308951858:

    CMake Error at CMakeLists.txt:1 (cmake_minimum_required):
      Compatibility with CMake < 3.5 has been removed from CMake.
@trofi
Copy link
Contributor Author

trofi commented Oct 17, 2025

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. labels Oct 17, 2025
@nix-owners nix-owners bot requested a review from wegank October 17, 2025 21:22
@trofi
Copy link
Contributor Author

trofi commented Oct 17, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 453042
Commit: 0ce964a8b273893dfff8c54b67704f330012b73e


x86_64-linux

✅ 4 packages built:
  • QuadProgpp
  • haskellPackages.hmatrix-quadprogpp
  • haskellPackages.hmatrix-quadprogpp.doc
  • nixpkgs-manual

Copy link
Member

@wegank wegank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks a lot!

@wegank wegank added this pull request to the merge queue Oct 17, 2025
Merged via the queue into NixOS:master with commit 20cf8ad Oct 17, 2025
30 of 34 checks passed
@trofi trofi deleted the QuadProgpp-cmake-4-fix branch October 17, 2025 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants