Skip to content

amule-gui: fix build with cmake4#453039

Merged
Sigmanificient merged 1 commit intoNixOS:masterfrom
Sigmanificient:amule-gui-cmake-fix
Oct 23, 2025
Merged

amule-gui: fix build with cmake4#453039
Sigmanificient merged 1 commit intoNixOS:masterfrom
Sigmanificient:amule-gui-cmake-fix

Conversation

@Sigmanificient
Copy link
Member

@Sigmanificient Sigmanificient commented Oct 17, 2025 •
edited
Loading

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@Sigmanificient Sigmanificient mentioned this pull request Oct 17, 2025
Open
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 9.needs: reviewer This PR currently has no reviewers requested and needs attention. labels Oct 17, 2025
@Sigmanificient
Copy link
Member Author

Sigmanificient commented Oct 18, 2025

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 453039
Commit: 000b7bd881b3387c412d549d2f389f483a6b560e (subsequent changes)
Merge: 249fd65eb03445a774337f1e96e82efe5381344e

Logs: https://github.com/Sigmanificient/nixpkgs-review-gha/actions/runs/18607544172

x86_64-linux

✅ 4 packages built:
  • amule
  • amule-daemon
  • amule-gui
  • amule-web

aarch64-linux

✅ 4 packages built:
  • amule
  • amule-daemon
  • amule-gui
  • amule-web

@dotlambda dotlambda linked an issue Oct 18, 2025 that may be closed by this pull request
amule-gui: Does not compile on unstable ( CMake 4 issue ) #453002
Closed
3 tasks
dotlambda
dotlambda reviewed Oct 18, 2025
View reviewed changes
@nixpkgs-ci nixpkgs-ci bot removed the 9.needs: reviewer This PR currently has no reviewers requested and needs attention. label Oct 18, 2025
@yzhou216
Copy link
Contributor

yzhou216 commented Oct 19, 2025

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 453039
Commit: 000b7bd881b3387c412d549d2f389f483a6b560e (subsequent changes)
Merge: 7df605fc4300093d3bf35acb90ab81fc578b5222

Logs: https://github.com/yzhou216/nixpkgs-review-gha/actions/runs/18625826961

Download packages from cache:
  • x86_64-linux 
    nix-store -r --add-root nixpkgs-pr-453039-x86_64-linux \
  --option binary-caches 'https://cache.nixos.org/ https://yzhou216.cachix.org' \
  --option trusted-public-keys '
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  yzhou216.cachix.org-1:O7nGwQnLGGBGE8zYFMipVzPVN956FcV57y9SqwEP+O8=
  ' \
  /nix/store/s1m7i4c31l9zgkn55a4m8hd46kndbnb8-amule-daemon-2.3.3 \
  /nix/store/b16n730vbzqpfj54jh749j2lmmwhvj8w-amule-gui-2.3.3 \
  /nix/store/hmqd3q9lmjj2b964i4c91bnf74x8lnzh-amule-web-2.3.3 \
  /nix/store/n1r6qhl9c9a887d2c5q1lhjmngyv7g3g-amule-2.3.3
  • aarch64-linux 
    nix-store -r --add-root nixpkgs-pr-453039-aarch64-linux \
  --option binary-caches 'https://cache.nixos.org/ https://yzhou216.cachix.org' \
  --option trusted-public-keys '
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  yzhou216.cachix.org-1:O7nGwQnLGGBGE8zYFMipVzPVN956FcV57y9SqwEP+O8=
  ' \
  /nix/store/xn8qm6l0al42xranks49ksxmmlz058l5-amule-2.3.3 \
  /nix/store/66pp9hichspxri1yiaibqyshqk8w8l5r-amule-daemon-2.3.3 \
  /nix/store/cyg91mwgpqlynr3dhhpla0wwz5vd3wmv-amule-gui-2.3.3 \
  /nix/store/wa3nxmdb7980avcp58b6anwq08hrgxy2-amule-web-2.3.3

x86_64-linux

✅ 4 packages built:
  • amule
  • amule-daemon
  • amule-gui
  • amule-web

aarch64-linux

✅ 4 packages built:
  • amule
  • amule-daemon
  • amule-gui
  • amule-web

x86_64-darwin

✅ No rebuilds

aarch64-darwin

✅ No rebuilds

yzhou216
yzhou216 approved these changes Oct 19, 2025
View reviewed changes
Copy link
Contributor

@yzhou216 yzhou216 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved automatically following the successful run of nixpkgs-review.

@nixpkgs-ci nixpkgs-ci bot added the 12.approvals: 1 This PR was reviewed and approved by one person. label Oct 19, 2025
@iedame
Copy link
Contributor

iedame commented Oct 19, 2025

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 453039
Commit: 000b7bd881b3387c412d549d2f389f483a6b560e (subsequent changes)
Merge: 097c42e58a3ecdc994c43fa4fd8a35ffc6ae5452

Logs: https://github.com/iedame/nixpkgs-review-gha/actions/runs/18628388829

x86_64-linux

✅ 4 packages built:
  • amule
  • amule-daemon
  • amule-gui
  • amule-web

aarch64-linux

✅ 4 packages built:
  • amule
  • amule-daemon
  • amule-gui
  • amule-web

x86_64-darwin

✅ No rebuilds

aarch64-darwin

✅ No rebuilds

@nixpkgs-ci nixpkgs-ci bot added 12.approvals: 2 This PR was reviewed and approved by two persons. and removed 12.approvals: 1 This PR was reviewed and approved by one person. labels Oct 19, 2025
@Sigmanificient Sigmanificient added this pull request to the merge queue Oct 23, 2025
Merged via the queue into NixOS:master with commit 5ddae33 Oct 23, 2025
36 of 38 checks passed
@Sigmanificient Sigmanificient deleted the amule-gui-cmake-fix branch October 23, 2025 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dotlambda dotlambda dotlambda left review comments

+2 more reviewers

@iedame iedame iedame approved these changes

@yzhou216 yzhou216 yzhou216 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 12.approvals: 2 This PR was reviewed and approved by two persons.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

amule-gui: Does not compile on unstable ( CMake 4 issue )

4 participants

@Sigmanificient @yzhou216 @iedame @dotlambda