Skip to content

pianobooster: use patch to fix cmake build failure#452954

Merged
ulrikstrid merged 1 commit intoNixOS:masterfrom
Sigmanificient:pianobooster-fix-cmake-take-2
Oct 17, 2025
Merged

pianobooster: use patch to fix cmake build failure#452954
ulrikstrid merged 1 commit intoNixOS:masterfrom
Sigmanificient:pianobooster-fix-cmake-take-2

Conversation

@Sigmanificient
Copy link
Member

@Sigmanificient Sigmanificient commented Oct 17, 2025 •
edited
Loading

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@nix-owners nix-owners bot requested a review from orivej October 17, 2025 15:04
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Oct 17, 2025
@Sigmanificient
Copy link
Member Author

Sigmanificient commented Oct 17, 2025

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 452954
Commit: 0416992bba13dc2261a1bc9b3df3f29b2d97c5de (subsequent changes)
Merge: 9a7da9eee4409252370ca64c79dc1c167dce2303

Logs: https://github.com/Sigmanificient/nixpkgs-review-gha/actions/runs/18596620802

x86_64-linux

✅ 1 package built:
  • pianobooster

aarch64-linux

✅ 1 package built:
  • pianobooster

x86_64-darwin

✅ No rebuilds

aarch64-darwin

✅ No rebuilds

@Sigmanificient
Copy link
Member Author

Sigmanificient commented Oct 17, 2025

@ulrikstrid

@ulrikstrid ulrikstrid added this pull request to the merge queue Oct 17, 2025
@Sigmanificient Sigmanificient mentioned this pull request Oct 17, 2025
Open
Merged via the queue into NixOS:master with commit 2499cbb Oct 17, 2025
30 of 34 checks passed
@nixpkgs-ci nixpkgs-ci bot added the 12.approvals: 1 This PR was reviewed and approved by one person. label Oct 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ulrikstrid ulrikstrid ulrikstrid approved these changes

@superherointj superherointj Awaiting requested review from superherointj

@orivej orivej Awaiting requested review from orivej

Assignees

No one assigned

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Sigmanificient @ulrikstrid