fna3d: fix CMake 4.0 incompatibility by upgrading to 25.10#452952
Merged
Sigmanificient merged 4 commits intoNixOS:masterfrom Oct 18, 2025
Merged
fna3d: fix CMake 4.0 incompatibility by upgrading to 25.10#452952Sigmanificient merged 4 commits intoNixOS:masterfrom
Sigmanificient merged 4 commits intoNixOS:masterfrom
Conversation
Upgrade FNA3D to version 25.10. 25.05 fixes CMake 4.0 compatibility. 25.03 builds against SDL3 by default. As I'm uncertain of whether this is a non-breaking change, I've opted to default to building against SDL2 still for nixpkgs (at least for now to get the CMake 4.0 incompatibility fixed). Other changes seem to be non-breaking. Diff: FNA-XNA/FNA3D@25.02...25.10 Changelog: https://github.com/FNA-XNA/FNA3D/releases
This ensures we install all shared libraries without manual intervention, as well as CMake and pkg-config files and headers.
fna3d does not provide any installable binaries, except for those built when tracing support is enabled (and it does not by default install those). Tracing support and associated binaries could be added as an optional feature, but currently require patching the CMakeLists.txt, or manual installation steps.
FNA3D is not licensed under the MS-PL, rather it is licensed under the zlib license. See https://github.com/FNA-XNA/FNA3D/blob/25.10/README and https://github.com/FNA-XNA/FNA3D/blob/25.10/LICENSE
nixpkgs-ci
bot
added
10.rebuild-linux: 1-10
nixpkgs-ci
bot
added
the
9.needs: reviewer
nixpkgs-ci
bot
removed
the
9.needs: reviewer
Member
|
Contributor
|
@NixOS/nixpkgs-merge-bot merge |
Contributor
This comment was marked as resolved.
This comment was marked as resolved.
Contributor
Author
|
Ah, damn it. I got myself confused over GitHub's display of merge commits. Sorry, please disregard the previous message. Thanks again |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Building some steam related FHSEnv I noticed that fna3d was broken due to the CMake 4.0 upgrade (see #445447). I've updated it to a version that includes a fix making it compatible again. The fix was introduced in 25.05. It switched to building against SDL3 by default in version 25.03. I've opted to still build it against SDL2 by default in nixpkgs, to avoid a breaking? change for now.
I have not yet had the chance to test its functionality, but the release notes indicate no further breaking changes to my understanding.
See https://github.com/FNA-XNA/FNA3D/releases.
In the process of this I've also attempted to clean up the package nix file a bit, fixing the
licenseandmainProgrammeta attributes, and removing the unnecessarily? specialised install phase (just using thecmakeInstallPhase).Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.Add a 👍 reaction to pull requests you find important.