pianobooster: fix CMake 4 build#452910
Merged
ulrikstrid merged 1 commit intoNixOS:masterfrom Oct 17, 2025
Merged
Conversation
superherointj
force-pushed
the
pianobooster-cmake-fix
branch
from
e2115e5 to
7c97ff0
Compare
nixpkgs-ci
bot
added
10.rebuild-linux: 1-10
Member
|
ulrikstrid
approved these changes
Oct 17, 2025
Member
nixpkgs-ci
bot
added
the
12.approvals: 1
Sigmanificient
requested changes
Oct 17, 2025
| ]; | ||
|
|
||
| cmakeFlags = [ | ||
| "-DCMAKE_POLICY_VERSION_MINIMUM=3.5" |
Member
There was a problem hiding this comment.
There is a pr open to fix this:
Although upstream is not active (so it probably wont be merged), we should have use it and vendored the patch
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pianobooster: fix CMake 4 build
CC @orivej