Skip to content

capstone_4, edb: fix build failure with cmake 4#452783

Merged
Sigmanificient merged 2 commits intoNixOS:masterfrom
drawbu:clement/push-yrykqmmutmpu
Oct 23, 2025
Merged

capstone_4, edb: fix build failure with cmake 4#452783
Sigmanificient merged 2 commits intoNixOS:masterfrom
drawbu:clement/push-yrykqmmutmpu

Conversation

@drawbu
Copy link
Member

@drawbu drawbu commented Oct 17, 2025 •
edited
Loading

Fix capstone_4 and edb (which depends on it) build failure on newer cmake 4.

CMake 4 is no longer retro compatible with versions < 3.5

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@drawbu
capstone_4: fix build failure with cmake 4
98a73f3 
- CMake 4 is no longer retro compatible with versions < 3.5
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. labels Oct 17, 2025
@drawbu drawbu marked this pull request as draft October 17, 2025 01:39
@nix-owners nix-owners bot requested review from risicle and thoughtpolice October 17, 2025 01:39
@nixpkgs-ci nixpkgs-ci bot added 9.needs: reviewer This PR currently has no reviewers requested and needs attention. and removed 9.needs: reviewer This PR currently has no reviewers requested and needs attention. labels Oct 17, 2025
@risicle
Copy link
Contributor

risicle commented Oct 17, 2025

The question must be raised - is there any need for capstone_4 any more? It's only reverse dependencies seem to be its own python library.

@drawbu
Copy link
Member Author

drawbu commented Oct 18, 2025 •
edited
Loading

The question must be raised - is there any need for capstone_4 any more? It's only reverse dependencies seem to be its own python library.

> rg capstone_4
pkgs/top-level/python-packages.nix
2345:  capstone_4 = callPackage ../development/python-modules/capstone/4.nix {
2346:    inherit (pkgs) capstone_4;

pkgs/top-level/all-packages.nix
1835:  capstone_4 = callPackage ../development/libraries/capstone/4.nix { };

pkgs/development/tools/misc/edb/default.nix
8:  capstone_4,
41:    capstone_4

pkgs/by-name/ze/zepp-simulator/package.nix
36:  capstone_4,
103:    capstone_4

pkgs/development/python-modules/capstone/4.nix
4:  capstone_4,
13:  inherit (capstone_4) version src;
15:  sourceRoot = "${capstone_4.src.name}/bindings/python";
27:    ln -s ${capstone_4}/lib/libcapstone${stdenv.targetPlatform.extensions.sharedLibrary} prebuilt/
28:    ln -s ${capstone_4}/lib/libcapstone${stdenv.targetPlatform.extensions.staticLibrary} prebuilt/

I am not sure about that, as edb seem to depend on it too (and zepp-simulator, but only for aarch64-linux target).

@drawbu
edb: fix build failure with cmake 4
4d8e8a4 
- CMake 4 is no longer retro compatible with versions < 3.5
@drawbu drawbu changed the title capstone_4: fix build failure with cmake 4 capstone_4, edb: fix build failure with cmake 4 Oct 18, 2025
@drawbu drawbu marked this pull request as ready for review October 18, 2025 19:47
@nix-owners nix-owners bot requested review from lihop and maxxk October 18, 2025 19:48
@drawbu
Copy link
Member Author

drawbu commented Oct 18, 2025

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 452783
Commit: 4d8e8a4c91ef3791d18163bc65290d2e6f0d7170 (subsequent changes)
Merge: 02455e07929b2c3f46d91d7a795cdb640b5cfcc9

Logs: https://github.com/drawbu/nixpkgs-review-gha/actions/runs/18620683005

x86_64-linux

✅ 6 packages built:
  • capstone_4
  • edb
  • python312Packages.capstone_4
  • python312Packages.capstone_4.dist
  • python313Packages.capstone_4
  • python313Packages.capstone_4.dist

aarch64-linux

✅ 6 packages built:
  • capstone_4
  • python312Packages.capstone_4
  • python312Packages.capstone_4.dist
  • python313Packages.capstone_4
  • python313Packages.capstone_4.dist
  • zepp-simulator

x86_64-darwin (sandbox = true)

✅ 5 packages built:
  • capstone_4
  • python312Packages.capstone_4
  • python312Packages.capstone_4.dist
  • python313Packages.capstone_4
  • python313Packages.capstone_4.dist

aarch64-darwin (sandbox = true)

✅ 5 packages built:
  • capstone_4
  • python312Packages.capstone_4
  • python312Packages.capstone_4.dist
  • python313Packages.capstone_4
  • python313Packages.capstone_4.dist

@risicle
Copy link
Contributor

risicle commented Oct 18, 2025

Oh, the first nixpkgs-review didn't show edb for some reason.

@risicle
Copy link
Contributor

risicle commented Oct 18, 2025

Although eteran/edb-debugger#839 suggests that edb now works with capstone 5.

@drawbu
Copy link
Member Author

drawbu commented Oct 18, 2025 •
edited
Loading

Oh, the first nixpkgs-review didn't show edb for some reason.

Yes, it was just failing because of cmake too ahah

It's why I repushed to add edb to the list fixed by this pr

Although eteran/edb-debugger#839 suggests that edb now works with capstone 5.

Just tested, and yeah mb for not seeing this. Although, I am not sure what would be the correct flow to update the capstone version used, as it does not really fit in the PR.

And either way, we still have zepp-simulator which seem to depend on it? (I don't have any way to test it tho, and it appears to be a whole lot of hack to make this package work, so...)

@Sigmanificient Sigmanificient mentioned this pull request Oct 18, 2025
Open
risicle
risicle approved these changes Oct 19, 2025
View reviewed changes
Copy link
Contributor

@risicle risicle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nixpkgs-review happy, x86_64 linux.

Unclear why edb restricts itself to x86_64 linux, but that's not a concern for this PR.

@nixpkgs-ci nixpkgs-ci bot added 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. labels Oct 19, 2025
@iedame
Copy link
Contributor

iedame commented Oct 20, 2025

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 452783
Commit: 4d8e8a4c91ef3791d18163bc65290d2e6f0d7170 (subsequent changes)
Merge: 131e8d1f34facb395818bb4439a394ec655156b8

Logs: https://github.com/iedame/nixpkgs-review-gha/actions/runs/18665070943

x86_64-linux

✅ 6 packages built:
  • capstone_4
  • edb
  • python312Packages.capstone_4
  • python312Packages.capstone_4.dist
  • python313Packages.capstone_4
  • python313Packages.capstone_4.dist

aarch64-linux

✅ 6 packages built:
  • capstone_4
  • python312Packages.capstone_4
  • python312Packages.capstone_4.dist
  • python313Packages.capstone_4
  • python313Packages.capstone_4.dist
  • zepp-simulator

x86_64-darwin (sandbox = true)

✅ 5 packages built:
  • capstone_4
  • python312Packages.capstone_4
  • python312Packages.capstone_4.dist
  • python313Packages.capstone_4
  • python313Packages.capstone_4.dist

aarch64-darwin (sandbox = true)

✅ 5 packages built:
  • capstone_4
  • python312Packages.capstone_4
  • python312Packages.capstone_4.dist
  • python313Packages.capstone_4
  • python313Packages.capstone_4.dist

@Sigmanificient Sigmanificient added this pull request to the merge queue Oct 23, 2025
Merged via the queue into NixOS:master with commit ce7e68b Oct 23, 2025
32 of 34 checks passed
@drawbu drawbu deleted the clement/push-yrykqmmutmpu branch October 23, 2025 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@risicle risicle risicle approved these changes

@thoughtpolice thoughtpolice Awaiting requested review from thoughtpolice

@lihop lihop Awaiting requested review from lihop

@maxxk maxxk Awaiting requested review from maxxk

Assignees

No one assigned

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@drawbu @risicle @iedame @Sigmanificient