Skip to content

openboardview: fix build with cmake 4#452764

Draft
Sigmanificient wants to merge 2 commits intoNixOS:masterfrom
Sigmanificient:openboardview-cmake-fix
Draft

openboardview: fix build with cmake 4#452764
Sigmanificient wants to merge 2 commits intoNixOS:masterfrom
Sigmanificient:openboardview-cmake-fix

Conversation

@Sigmanificient
Copy link
Member

@Sigmanificient Sigmanificient commented Oct 16, 2025 •
edited
Loading

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@Sigmanificient Sigmanificient mentioned this pull request Oct 16, 2025
Open
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. labels Oct 16, 2025
@nix-owners nix-owners bot requested a review from k3a October 16, 2025 23:56
@iedame
Copy link
Contributor

iedame commented Oct 17, 2025

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 452764
Commit: 2d7a3ca507fb963a8a4564ad80ad65dd04b86989 (subsequent changes)
Merge: a427194912b021820e92d8024e48aba47add396a

Logs: https://github.com/iedame/nixpkgs-review-gha/actions/runs/18578743193

x86_64-linux

✅ 2 packages built:
  • openboardview
  • tests.pkgs-lib

aarch64-linux

✅ 2 packages built:
  • openboardview
  • tests.pkgs-lib

x86_64-darwin (sandbox = true)

❌ 1 package failed to build:
  • openboardview
✅ 1 package built:
  • tests.pkgs-lib
Error logs: `x86_64-darwin`
openboardview 
      |                         ^
/nix/build/nix-5986-118784263/source/src/openboardview/confparse.cpp:508:12: error: '~path' is unavailable: introduced in macOS 10.15
  508 |                                                 auto nfn = filepath;
      |                                                      ^
/nix/store/b4fhdw54iry97k2cx758xmmjmawmwbhv-libcxx-19.1.2+apple-sdk-15.5/include/c++/v1/__filesystem/path.h:434:25: note: '~path' has been explicitly marked unavailable here
  434 |   _LIBCPP_HIDE_FROM_ABI ~path() = default;
      |                         ^
/nix/build/nix-5986-118784263/source/src/openboardview/confparse.cpp:509:11: error: 'operator+=' is unavailable: introduced in macOS 10.15
  509 |                                                 nfn += "~";
      |                                                     ^
/nix/store/b4fhdw54iry97k2cx758xmmjmawmwbhv-libcxx-19.1.2+apple-sdk-15.5/include/c++/v1/__filesystem/path.h:575:31: note: 'operator+=' has been explicitly marked unavailable here
  575 |   _LIBCPP_HIDE_FROM_ABI path& operator+=(const value_type* __x) {
      |                               ^
fatal error: too many errors emitted, stopping now [-ferror-limit=]
20 errors generated.
make[2]: *** [src/openboardview/CMakeFiles/openboardview.dir/build.make:102: src/openboardview/CMakeFiles/openboardview.dir/confparse.cpp.o] Error 1
make[2]: *** Waiting for unfinished jobs....
3 warnings generated.
make[1]: *** [CMakeFiles/Makefile2:364: src/openboardview/CMakeFiles/openboardview.dir/all] Error 2
make: *** [Makefile:156: all] Error 2

aarch64-darwin (sandbox = true)

❌ 1 package failed to build:
  • openboardview
✅ 1 package built:
  • tests.pkgs-lib
Error logs: `aarch64-darwin`
openboardview 
      |                         ^
/nix/build/nix-6087-2745161286/source/src/openboardview/confparse.cpp:508:12: error: '~path' is unavailable: introduced in macOS 10.15
  508 |                                                 auto nfn = filepath;
      |                                                      ^
/nix/store/zzn2cvbh4gs4zvyv9p52kclqqvqrfb5x-libcxx-19.1.2+apple-sdk-15.5/include/c++/v1/__filesystem/path.h:434:25: note: '~path' has been explicitly marked unavailable here
  434 |   _LIBCPP_HIDE_FROM_ABI ~path() = default;
      |                         ^
/nix/build/nix-6087-2745161286/source/src/openboardview/confparse.cpp:509:11: error: 'operator+=' is unavailable: introduced in macOS 10.15
  509 |                                                 nfn += "~";
      |                                                     ^
/nix/store/zzn2cvbh4gs4zvyv9p52kclqqvqrfb5x-libcxx-19.1.2+apple-sdk-15.5/include/c++/v1/__filesystem/path.h:575:31: note: 'operator+=' has been explicitly marked unavailable here
  575 |   _LIBCPP_HIDE_FROM_ABI path& operator+=(const value_type* __x) {
      |                               ^
fatal error: too many errors emitted, stopping now [-ferror-limit=]
20 errors generated.
make[2]: *** [src/openboardview/CMakeFiles/openboardview.dir/build.make:102: src/openboardview/CMakeFiles/openboardview.dir/confparse.cpp.o] Error 1
make[2]: *** Waiting for unfinished jobs....
3 warnings generated.
make[1]: *** [CMakeFiles/Makefile2:364: src/openboardview/CMakeFiles/openboardview.dir/all] Error 2
make: *** [Makefile:156: all] Error 2

@k3a
Copy link
Contributor

k3a commented Oct 17, 2025 •
edited
Loading

Adding this

    substituteInPlace CMakeLists.txt \
        --replace 'CMAKE_OSX_DEPLOYMENT_TARGET "10.9"' 'CMAKE_OSX_DEPLOYMENT_TARGET "10.15"'

to postPatch fixes it, it builds and runs fine on MacOS 26 Tahoe.

It is not the cleanest way though, an upstream patch would probably be a better long-term fix, but maybe good enough in the mean-time?

@k3a k3a mentioned this pull request Oct 17, 2025
Closed
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Oct 17, 2025
@iedame
Copy link
Contributor

iedame commented Oct 19, 2025

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 452764
Commit: b377d6e314de34a01f93002780435e842b1cf7c4 (subsequent changes)
Merge: 3246da8a2f14a69b2473b28d57094dbbc64b7da6

Logs: https://github.com/iedame/nixpkgs-review-gha/actions/runs/18628320045

x86_64-linux

✅ 1 package built:
  • openboardview

aarch64-linux

✅ 1 package built:
  • openboardview

x86_64-darwin (sandbox = true)

✅ 1 package built:
  • openboardview

aarch64-darwin (sandbox = true)

✅ 1 package built:
  • openboardview

@nixpkgs-ci nixpkgs-ci bot added the 12.approvals: 1 This PR was reviewed and approved by one person. label Oct 19, 2025
@k3a
Copy link
Contributor

k3a commented Oct 19, 2025

Wait a bit please. I am working on it actively and I think we might be able to get 9.95.2 version with a new single patch which will hopefully also get upstream.

@Sigmanificient
Copy link
Member Author

Sigmanificient commented Oct 19, 2025

@k3a that would be awesome, I will put this in draft for now then!

@Sigmanificient Sigmanificient marked this pull request as draft October 19, 2025 12:34
@k3a k3a mentioned this pull request Oct 19, 2025
Closed
13 tasks
@nixpkgs-ci nixpkgs-ci bot added the 2.status: merge-bot eligible This PR can be merged by commenting "@NixOS/nixpkgs-merge-bot merge". label Nov 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@k3a k3a Awaiting requested review from k3a

1 more reviewer

@iedame iedame iedame approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

2.status: merge-bot eligible This PR can be merged by commenting "@NixOS/nixpkgs-merge-bot merge". 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Sigmanificient @iedame @k3a