Skip to content

nixos/systemd-initrd: only include glibc nss modules on gnu systems#452738

Merged
vcunat merged 1 commit intoNixOS:staging-nextfrom
MatthewCroughan:mc/conditional-glibcsystemdinitrd
Oct 20, 2025
Merged

nixos/systemd-initrd: only include glibc nss modules on gnu systems#452738
vcunat merged 1 commit intoNixOS:staging-nextfrom
MatthewCroughan:mc/conditional-glibcsystemdinitrd

Conversation

@MatthewCroughan
Copy link
Contributor

@MatthewCroughan MatthewCroughan commented Oct 16, 2025

Things done

nss modules don't make sense on musl anyway, and this causes glibc to leak into a system configured to be musl only

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 6.topic: systemd Software suite that provides an array of system components for Linux operating systems. labels Oct 16, 2025
ElvishJerricco
ElvishJerricco reviewed Oct 17, 2025
View reviewed changes
@MatthewCroughan MatthewCroughan force-pushed the mc/conditional-glibcsystemdinitrd branch from 3f53ecb to d68905d Compare October 17, 2025 03:51
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. and removed 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. labels Oct 17, 2025
@MatthewCroughan MatthewCroughan force-pushed the mc/conditional-glibcsystemdinitrd branch from d68905d to 858860c Compare October 18, 2025 00:28
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. and removed 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. labels Oct 18, 2025
@MatthewCroughan MatthewCroughan force-pushed the mc/conditional-glibcsystemdinitrd branch from 858860c to 253a016 Compare October 18, 2025 13:20
@vcunat vcunat merged commit 5e6d789 into NixOS:staging-next Oct 20, 2025
28 of 30 checks passed
@vcunat
Copy link
Member

vcunat commented Oct 20, 2025

Sounds OK.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@flokli flokli Awaiting requested review from flokli

@aanderse aanderse Awaiting requested review from aanderse

@LordGrimmauld LordGrimmauld Awaiting requested review from LordGrimmauld

@arianvp arianvp Awaiting requested review from arianvp

@ElvishJerricco ElvishJerricco Awaiting requested review from ElvishJerricco

@nikstur nikstur Awaiting requested review from nikstur

Assignees

No one assigned

Labels

6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 6.topic: systemd Software suite that provides an array of system components for Linux operating systems. 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@MatthewCroughan @vcunat @ElvishJerricco