Skip to content

msnake: fix build failure with cmake 4#452717

Merged
Sigmanificient merged 1 commit intoNixOS:masterfrom
ethancedwards8:msnake-cmake-fix
Oct 16, 2025
Merged

msnake: fix build failure with cmake 4#452717
Sigmanificient merged 1 commit intoNixOS:masterfrom
ethancedwards8:msnake-cmake-fix

Conversation

@ethancedwards8
Copy link
Member

@ethancedwards8 ethancedwards8 commented Oct 16, 2025

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@ethancedwards8 ethancedwards8 added the 0.kind: ZHF Fixes Fixes during the Zero Hydra Failures (ZHF) campaign label Oct 16, 2025
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. labels Oct 16, 2025
Sigmanificient
Sigmanificient requested changes Oct 16, 2025
View reviewed changes
@Sigmanificient Sigmanificient mentioned this pull request Oct 16, 2025
Open
@ethancedwards8
msnake: fix build failure with cmake 4
4d4cf8f 
Signed-off-by: Ethan Carter Edwards <[email protected]>
@Sigmanificient
Copy link
Member

Sigmanificient commented Oct 16, 2025

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 452717
Commit: 4d4cf8fa3c9238e9b1684d496d7fa309004d0b67 (subsequent changes)
Merge: 95a2ce4198fd2bd9d5d0f8a0baf5f3373fa37b30

Logs: https://github.com/Sigmanificient/nixpkgs-review-gha/actions/runs/18575856676

x86_64-linux

✅ 2 packages built:
  • msnake
  • tests.pkgs-lib

aarch64-linux

✅ 2 packages built:
  • msnake
  • tests.pkgs-lib

x86_64-darwin (sandbox = true)

✅ 2 packages built:
  • msnake
  • tests.pkgs-lib

aarch64-darwin (sandbox = true)

✅ 2 packages built:
  • msnake
  • tests.pkgs-lib

@Sigmanificient Sigmanificient added this pull request to the merge queue Oct 16, 2025
Merged via the queue into NixOS:master with commit 7c76c6c Oct 16, 2025
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Sigmanificient Sigmanificient Sigmanificient approved these changes

Assignees

No one assigned

Labels

0.kind: ZHF Fixes Fixes during the Zero Hydra Failures (ZHF) campaign 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ethancedwards8 @Sigmanificient