Skip to content

blas-reference: fix build failure with cmake 4#452693

Merged
markuskowa merged 1 commit intoNixOS:masterfrom
drawbu:clement/push-pvrnsnvxquor
Oct 16, 2025
Merged

blas-reference: fix build failure with cmake 4#452693
markuskowa merged 1 commit intoNixOS:masterfrom
drawbu:clement/push-pvrnsnvxquor

Conversation

@drawbu
Copy link
Member

@drawbu drawbu commented Oct 16, 2025

Fix blas-reference build failure on newer cmake 4.

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@drawbu
blas-reference: fix build failure with cmake 4
0efc728 
- CMake 4 is no longer retro compatible with versions < 3.5
@drawbu
Copy link
Member Author

drawbu commented Oct 16, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review
Commit: 0efc7281d7910a7d3dec3129277d687497b98f7f

x86_64-linux

✅ 1 package built:
  • blas-reference

@Sigmanificient Sigmanificient mentioned this pull request Oct 16, 2025
Open
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Oct 16, 2025
@nix-owners nix-owners bot requested a review from markuskowa October 16, 2025 19:32
@markuskowa markuskowa added this pull request to the merge queue Oct 16, 2025
Merged via the queue into NixOS:master with commit 4260476 Oct 16, 2025
29 checks passed
@Sigmanificient
Copy link
Member

Sigmanificient commented Oct 16, 2025

@markuskowa Small tip for next cmake4 related pr: try to see if it would be possible to bump higher than cmake 3.5, because having 3.10+ would be preferable and keep packages working for longer 😄

@markuskowa
Copy link
Member

markuskowa commented Oct 16, 2025

@markuskowa Small tip for next cmake4 related pr: try to see if it would be possible to bump higher than cmake 3.5, because having 3.10+ would be preferable and keep packages working for longer 😄

I do not think this is super relevant. These patches will disappear hopefully soon with upstream upgrades.
I rather get fixes merged quickly than spending a lot of time on minor review comments.

@Sigmanificient
Copy link
Member

Sigmanificient commented Oct 16, 2025

I also agree that getting things merged rapidly is nice, but we should still consider the review carefully. I think this should also have been a bump to v3.12.1

@drawbu
Copy link
Member Author

drawbu commented Oct 16, 2025

Woops by bad! I should have spotted that too :(

@drawbu drawbu deleted the clement/push-pvrnsnvxquor branch October 16, 2025 20:23
@Sigmanificient
Copy link
Member

Sigmanificient commented Oct 16, 2025

Since blas gets shipped into lapack, we probably should consider carefully what to do

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@markuskowa markuskowa Awaiting requested review from markuskowa

Assignees

No one assigned

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@drawbu @Sigmanificient @markuskowa