Skip to content

blitz: fix build failure with cmake 4#452691

Merged
Sigmanificient merged 1 commit intoNixOS:masterfrom
drawbu:clement/push-mvqyzvttotzl
Oct 23, 2025
Merged

blitz: fix build failure with cmake 4#452691
Sigmanificient merged 1 commit intoNixOS:masterfrom
drawbu:clement/push-mvqyzvttotzl

Conversation

@drawbu
Copy link
Member

@drawbu drawbu commented Oct 16, 2025

Fix blitz build failure on newer cmake 4.

CMake 4 is no longer retro compatible with versions < 3.5 cmake_minimum_required was already to an upper version, but not cmake_policy

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

- CMake 4 is no longer retro compatible with versions < 3.5
  cmake_minimum_required was already to an upper version, but not cmake_policy
@drawbu
Copy link
Member Author

drawbu commented Oct 16, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review
Commit: 84ad49bfa2d62b26c83772bfa6266ec2d014ddfb


x86_64-linux

✅ 1 package built:
  • blitz

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Oct 16, 2025
@nix-owners nix-owners bot requested a review from ToxicFrog October 16, 2025 19:26
@Sigmanificient Sigmanificient added this pull request to the merge queue Oct 23, 2025
Merged via the queue into NixOS:master with commit 22ed591 Oct 23, 2025
34 checks passed
@drawbu drawbu deleted the clement/push-mvqyzvttotzl branch October 23, 2025 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants