Skip to content

dabtools: fix build failure with cmake 4#452689

Merged
markuskowa merged 1 commit intoNixOS:masterfrom
drawbu:clement/push-llzuqoptnmol
Oct 16, 2025
Merged

dabtools: fix build failure with cmake 4#452689
markuskowa merged 1 commit intoNixOS:masterfrom
drawbu:clement/push-llzuqoptnmol

Conversation

@drawbu
Copy link
Member

@drawbu drawbu commented Oct 16, 2025

Fix lugaru build failure on newer cmake 4.

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

- CMake 4 is no longer retro compatible with versions < 3.5
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Oct 16, 2025
@nix-owners nix-owners bot requested a review from markuskowa October 16, 2025 19:22
@drawbu
Copy link
Member Author

drawbu commented Oct 16, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 452689
Commit: 739d7af5d2526013313df9c5adb3bd6c849bcae2


x86_64-linux

✅ 1 package built:
  • dabtools

@markuskowa markuskowa added this pull request to the merge queue Oct 16, 2025
Merged via the queue into NixOS:master with commit ff84020 Oct 16, 2025
29 checks passed
@drawbu drawbu deleted the clement/push-llzuqoptnmol branch October 16, 2025 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants