Skip to content

lugaru: fix build failure with cmake 4#452681

Merged
Sigmanificient merged 1 commit intoNixOS:masterfrom
drawbu:clement/push-ukyswmlyvwps
Oct 16, 2025
Merged

lugaru: fix build failure with cmake 4#452681
Sigmanificient merged 1 commit intoNixOS:masterfrom
drawbu:clement/push-ukyswmlyvwps

Conversation

@drawbu
Copy link
Member

@drawbu drawbu commented Oct 16, 2025

Fix lugaru build failure on newer cmake 4.

  • Tracking: Build Failures with CMake 4 #445447

  • CMake 4 is no longer retro compatible with versions < 3.5

  • CMake Error at CMakeLists.txt:4 (cmake_policy): Policy CMP0004 may not be set to OLD behavior because this version of CMake no longer supports it. The policy was introduced in CMake version 2.6.0, and use of NEW behavior is now required.

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@drawbu
Copy link
Member Author

drawbu commented Oct 16, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 452681
Commit: e175b4881e38985059640b8a0e5ba6c8e42e8182


x86_64-linux

✅ 1 package built:
  • lugaru

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 9.needs: reviewer This PR currently has no reviewers requested and needs attention. labels Oct 16, 2025
@drawbu drawbu force-pushed the clement/push-ukyswmlyvwps branch from e175b48 to 677ae70 Compare October 16, 2025 20:07
Copy link
Member

@Sigmanificient Sigmanificient left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TYSM, running nixpkgs-review

- CMake 4 is no longer retro compatible with versions < 3.5
- CMake Error at CMakeLists.txt:4 (cmake_policy):
  Policy CMP0004 may not be set to OLD behavior because this version of CMake
  no longer supports it.  The policy was introduced in CMake version 2.6.0,
  and use of NEW behavior is now required.
@drawbu drawbu force-pushed the clement/push-ukyswmlyvwps branch from 677ae70 to a42fe9f Compare October 16, 2025 20:11
@nixpkgs-ci nixpkgs-ci bot added 12.approvals: 1 This PR was reviewed and approved by one person. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. and removed 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Oct 16, 2025
@drawbu
Copy link
Member Author

drawbu commented Oct 16, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 452681
Commit: a42fe9feb3c431d4dcb6989acf284b6d5e2605fc


x86_64-linux

✅ 2 packages built:
  • lugaru
  • tests.pkgs-lib

@nixpkgs-ci nixpkgs-ci bot removed the 9.needs: reviewer This PR currently has no reviewers requested and needs attention. label Oct 16, 2025
@Sigmanificient Sigmanificient added this pull request to the merge queue Oct 16, 2025
Merged via the queue into NixOS:master with commit d74c218 Oct 16, 2025
28 checks passed
@drawbu drawbu deleted the clement/push-ukyswmlyvwps branch October 16, 2025 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants