luabind, eigen2, soi: fix build with cmake 4#452677
Merged
7c6f434c merged 3 commits intoNixOS:masterfrom Oct 21, 2025
Merged
Conversation
nixpkgs-ci
bot
added
10.rebuild-linux: 1-10
nixpkgs-ci
bot
added
9.needs: reviewer
- CMake 4 is no longer retro compatible with versions < 3.5 - Should fix `luabind`, `luabind_luajit` & `osrm-backend`
- CMake 4 is no longer retro compatible with versions < 3.5 - CMake Error at doc/snippets/CMakeLists.txt:17 (GET_TARGET_PROPERTY): The LOCATION property may not be read from target "compile_class_LU". Use the target name directly with add_custom_command, or use the generator expression $<TARGET_FILE>, as appropriate. - CMake Error at doc/examples/CMakeLists.txt:11 (GET_TARGET_PROPERTY): The LOCATION property may not be read from target "Tutorial_simple_example_dynamic_size". Use the target name directly with add_custom_command, or use the generator expression $<TARGET_FILE>, as appropriate.
- CMake 4 is no longer retro compatible with versions < 3.5 - PROJECT_VERSION variable was now overwritten by the call to project() function so updating how the version was set has been needed.
drawbu
force-pushed
the
clement/push-zqvklkyqromu
branch
from
a7d5edc to
0705992
Compare
Member
Author
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix
luabind,eigen2andsoibuild failure and its dependencies on newer cmake 4.This should fix build for:
luabindluabind_luajitosrm-backendosmscout-servereigen2soiShould help for:
Also,
iceslwhich depends onluabindfails to build, but it is unrelated to the CMake failure.Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.Add a 👍 reaction to pull requests you find important.