Skip to content

mjpg-streamer: add patch to fix for CMake 4#452606

Merged
Sigmanificient merged 1 commit intoNixOS:masterfrom
minionflo:fix-mjpg-streamer
Oct 23, 2025
Merged

mjpg-streamer: add patch to fix for CMake 4#452606
Sigmanificient merged 1 commit intoNixOS:masterfrom
minionflo:fix-mjpg-streamer

Conversation

@minionflo
Copy link

@minionflo minionflo commented Oct 16, 2025 •
edited
Loading

Currently the build is failing because of #445447.

Things done

Added a Patch to workaround #445447 for mjpg-streamer

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 12.first-time contribution This PR is the author's first one; please be gentle! 9.needs: reviewer This PR currently has no reviewers requested and needs attention. labels Oct 16, 2025
@Sigmanificient Sigmanificient mentioned this pull request Oct 16, 2025
Open
@Sigmanificient
Copy link
Member

Sigmanificient commented Oct 17, 2025

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 452606
Commit: 632d7f7d02e52b2920adeb839833d56b346f8985 (subsequent changes)
Merge: b10eb5f0170ba4b109d2a4d4a4f18dee6fb7e276

Logs: https://github.com/Sigmanificient/nixpkgs-review-gha/actions/runs/18600624957

x86_64-linux

✅ 1 package built:
  • mjpg-streamer

aarch64-linux

✅ 1 package built:
  • mjpg-streamer

mdaniels5757
mdaniels5757 approved these changes Oct 20, 2025
View reviewed changes
Copy link
Member

@mdaniels5757 mdaniels5757 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but please change the words "fix #445447" in the description so the tracking issue isn't automatically closed.

@nixpkgs-ci nixpkgs-ci bot added 12.approvals: 1 This PR was reviewed and approved by one person. and removed 9.needs: reviewer This PR currently has no reviewers requested and needs attention. labels Oct 20, 2025
@minionflo
Copy link
Author

minionflo commented Oct 20, 2025

LGTM, but please change the words "fix #445447" in the description so the tracking issue isn't automatically closed.

Done

@Sigmanificient Sigmanificient added this pull request to the merge queue Oct 23, 2025
Merged via the queue into NixOS:master with commit 1741c4f Oct 23, 2025
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mdaniels5757 mdaniels5757 Awaiting requested review from mdaniels5757

Assignees

No one assigned

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person. 12.first-time contribution This PR is the author's first one; please be gentle!

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@minionflo @Sigmanificient @mdaniels5757