Skip to content

edlib: fix build with cmake#452584

Merged
JohnRTitor merged 1 commit intoNixOS:masterfrom
Sigmanificient:edlib-cmake-fix
Oct 16, 2025
Merged

edlib: fix build with cmake#452584
JohnRTitor merged 1 commit intoNixOS:masterfrom
Sigmanificient:edlib-cmake-fix

Conversation

@Sigmanificient
Copy link
Member

@Sigmanificient Sigmanificient commented Oct 16, 2025

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. labels Oct 16, 2025
@nix-owners nix-owners bot requested a review from bcdarwin October 16, 2025 12:54
@bcdarwin
Copy link
Member

bcdarwin commented Oct 16, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 452584
Commit: 0897ebc3e24c396c03a4a0b37062e081472017ab

x86_64-linux

✅ 5 packages built:
  • edlib
  • python312Packages.edlib
  • python312Packages.edlib.dist
  • python313Packages.edlib
  • python313Packages.edlib.dist

bcdarwin
bcdarwin approved these changes Oct 16, 2025
View reviewed changes
Copy link
Member

@bcdarwin bcdarwin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for fix.

@nixpkgs-ci nixpkgs-ci bot added 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. labels Oct 16, 2025
@JohnRTitor JohnRTitor added this pull request to the merge queue Oct 16, 2025
Merged via the queue into NixOS:master with commit 34420d4 Oct 16, 2025
29 checks passed
@dotlambda dotlambda mentioned this pull request Oct 21, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@bcdarwin bcdarwin bcdarwin approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Sigmanificient @bcdarwin @JohnRTitor