Skip to content

leatherman, cpp-hocon, libwhereami: fix build failure with cmake 4#452446

Merged
Sigmanificient merged 3 commits intoNixOS:masterfrom
drawbu:clement/push-wkmslpmmrpwq
Oct 23, 2025
Merged

leatherman, cpp-hocon, libwhereami: fix build failure with cmake 4#452446
Sigmanificient merged 3 commits intoNixOS:masterfrom
drawbu:clement/push-wkmslpmmrpwq

Conversation

@drawbu
Copy link
Member

@drawbu drawbu commented Oct 16, 2025

Fix leatherman and its dependant pacakges, cpp-hocon & libwhereami, build failure on newer cmake 4.

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@drawbu
Copy link
Member Author

drawbu commented Oct 16, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 452446
Commit: b65375a5fa2071e8ef8f9262c568fa10b8f643c3


x86_64-linux

✅ 3 packages built:
  • cpp-hocon
  • leatherman
  • libwhereami

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. labels Oct 16, 2025
@nix-owners nix-owners bot requested a review from womfoo October 16, 2025 01:52
@Sigmanificient
Copy link
Member

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 452446
Commit: b65375a5fa2071e8ef8f9262c568fa10b8f643c3 (subsequent changes)
Merge: dd9422b0d7c3854659e687fd5938d75252dd6601

Logs: https://github.com/Sigmanificient/nixpkgs-review-gha/actions/runs/18556038817


x86_64-linux

✅ 3 packages built:
  • cpp-hocon
  • leatherman
  • libwhereami

aarch64-linux

✅ 2 packages built:
  • cpp-hocon
  • leatherman

x86_64-darwin (sandbox = true)

✅ 3 packages built:
  • cpp-hocon
  • leatherman
  • libwhereami

aarch64-darwin (sandbox = true)

✅ 2 packages built:
  • cpp-hocon
  • leatherman

@drawbu drawbu force-pushed the clement/push-wkmslpmmrpwq branch from b65375a to 49c3e69 Compare October 16, 2025 20:10
- CMake 4 is no longer retro compatible with versions < 3.5
- CMake 4 is no longer retro compatible with versions < 3.5
- CMake 4 is no longer retro compatible with versions < 3.5
@drawbu drawbu force-pushed the clement/push-wkmslpmmrpwq branch from 49c3e69 to e0e6288 Compare October 16, 2025 20:12
@drawbu
Copy link
Member Author

drawbu commented Oct 16, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 452446
Commit: e0e6288837dca9720dfdcbd9ab516ab02e8c14ce


x86_64-linux

✅ 4 packages built:
  • cpp-hocon
  • leatherman
  • libwhereami
  • tests.pkgs-lib

@Sigmanificient Sigmanificient added this pull request to the merge queue Oct 23, 2025
Merged via the queue into NixOS:master with commit 597f7b0 Oct 23, 2025
25 checks passed
@drawbu drawbu deleted the clement/push-wkmslpmmrpwq branch October 23, 2025 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants