Skip to content

taco: fix build failure with cmake 4#452442

Merged
h7x4 merged 1 commit intoNixOS:masterfrom
drawbu:clement/push-snsorpyynrqx
Oct 16, 2025
Merged

taco: fix build failure with cmake 4#452442
h7x4 merged 1 commit intoNixOS:masterfrom
drawbu:clement/push-snsorpyynrqx

Conversation

@drawbu
Copy link
Member

@drawbu drawbu commented Oct 16, 2025 •
edited
Loading

Fix taco build failure on newer cmake 4.

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@drawbu
taco: fix build failure with cmake 4
970542b 
- CMake 4 is no longer retro compatible with versions < 3.5
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. labels Oct 16, 2025
@nix-owners nix-owners bot requested a review from sheepforce October 16, 2025 01:38
@drawbu
Copy link
Member Author

drawbu commented Oct 16, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 452442
Commit: 970542b879f84aab03fe1b9410c4222418ef9871

x86_64-linux

✅ 3 packages built:
  • python312Packages.taco
  • python313Packages.taco
  • taco

@Sigmanificient Sigmanificient mentioned this pull request Oct 16, 2025
Open
sheepforce
sheepforce approved these changes Oct 16, 2025
View reviewed changes
Copy link
Member

@sheepforce sheepforce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much, LGTM. 🐑

@h7x4 h7x4 added this pull request to the merge queue Oct 16, 2025
@nixpkgs-ci nixpkgs-ci bot added 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. labels Oct 16, 2025
Merged via the queue into NixOS:master with commit eb14475 Oct 16, 2025
30 checks passed
@drawbu drawbu deleted the clement/push-snsorpyynrqx branch October 16, 2025 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@sheepforce sheepforce sheepforce approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@drawbu @sheepforce @h7x4