opensoldat: unstable-2022-07-02 -> unstable-2024-04-21#452334
Merged
vcunat merged 1 commit intoNixOS:masterfrom Nov 8, 2025
Merged
opensoldat: unstable-2022-07-02 -> unstable-2024-04-21#452334vcunat merged 1 commit intoNixOS:masterfrom
vcunat merged 1 commit intoNixOS:masterfrom
Conversation
nixpkgs-ci
bot
added
10.rebuild-linux: 1-10
sternenseemann
requested changes
Oct 15, 2025
Member
sternenseemann
left a comment
sternenseemann
left a comment
There was a problem hiding this comment.
Initial comments, haven't had a chance to test it yet.
gileri
force-pushed
the
opensoldat-unstable-2024-04-21
branch
from
afeaeed to
aa58ee0
Compare
sternenseemann
previously requested changes
Oct 17, 2025
gileri
force-pushed
the
opensoldat-unstable-2024-04-21
branch
2 times, most recently
from
f015067 to
519ad00
Compare
gileri
force-pushed
the
opensoldat-unstable-2024-04-21
branch
from
519ad00 to
9403884
Compare
nixpkgs-ci
bot
added
10.rebuild-darwin: 1-10
13 tasks
Member
|
If we bump to opensoldat @ 220468f558f6932ba1dc180a9ef84913d07ab324, we can drop all patches, right? |
gileri
force-pushed
the
opensoldat-unstable-2024-04-21
branch
from
9403884 to
eb9864b
Compare
Contributor
Author
There were "breaking" changes in more recent commits, but I guess since this is an alpha anyway, we should target latest commit when updating indeed. I've tried building and running with the latest changes. |
Member
|
Let's merge at least some fix. Feel free to continue improvements afterwards. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Things done
Updated package to latest stable release, ensured compatibility with recent CMake requirements.
The output bins names have been prefixed with
open, I mirrored the change for binaries and configuration alike.passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.Add a 👍 reaction to pull requests you find important.