Skip to content

nextpnr: Fix build the easy way#452270

Merged
Artturin merged 1 commit intoNixOS:masterfrom
Artturin:nextpnrbuild
Oct 16, 2025
Merged

nextpnr: Fix build the easy way#452270
Artturin merged 1 commit intoNixOS:masterfrom
Artturin:nextpnrbuild

Conversation

@Artturin
Copy link
Member

@Artturin Artturin commented Oct 15, 2025

CMake Error at 3rdparty/googletest/googletest/CMakeLists.txt:48 (cmake_minimum_required):
  Compatibility with CMake < 3.5 has been removed from CMake.

https://www.github.com/YosysHQ/nextpnr/issues/1578

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

```
CMake Error at 3rdparty/googletest/googletest/CMakeLists.txt:48 (cmake_minimum_required):
  Compatibility with CMake < 3.5 has been removed from CMake.
```

https://www.github.com/YosysHQ/nextpnr/issues/1578
@nix-owners nix-owners bot requested a review from thoughtpolice October 15, 2025 14:32
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. labels Oct 15, 2025
@Artturin
Copy link
Member Author

Merging to fix the build issue.

Before this fix breaks, the upstream will probably have merged YosysHQ/nextpnr#1579 to address the issue properly

@Artturin Artturin enabled auto-merge October 16, 2025 10:48
@Artturin Artturin added this pull request to the merge queue Oct 16, 2025
Merged via the queue into NixOS:master with commit cd0e4e4 Oct 16, 2025
28 checks passed
@Artturin Artturin deleted the nextpnrbuild branch October 16, 2025 10:53
@carlossless carlossless mentioned this pull request Nov 5, 2025
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant