Skip to content

pigpio: fix after cmake update#452193

Merged
doronbehar merged 1 commit intoNixOS:masterfrom
mcdonc:fix-pigpio
Oct 16, 2025
Merged

pigpio: fix after cmake update#452193
doronbehar merged 1 commit intoNixOS:masterfrom
mcdonc:fix-pigpio

Conversation

@mcdonc
Copy link
Contributor

@mcdonc mcdonc commented Oct 15, 2025 •
edited
Loading

Fix PiGPIO compilation after cmake upgrade.

Things done

Added cmakeFlag to permit newer cmake versions.

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. labels Oct 15, 2025
@nix-owners nix-owners bot requested a review from doronbehar October 15, 2025 08:42
@doronbehar
Copy link
Contributor

doronbehar commented Oct 15, 2025

Thanks for the fix. Please read CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

@doronbehar
Copy link
Contributor

doronbehar commented Oct 15, 2025

Note in the markdown, instead of:

- [X ] x86_64-linux
- [ X] aarch64-linux

Use:

- [X] x86_64-linux
- [X] aarch64-linux

Which will render as:

  • x86_64-linux
  • aarch64-linux

doronbehar
doronbehar requested changes Oct 15, 2025
View reviewed changes
@mcdonc mcdonc changed the title fix pigpio after cmake update pigpio: fix after cmake update Oct 15, 2025
@mcdonc mcdonc requested a review from doronbehar October 15, 2025 17:24
@doronbehar
Copy link
Contributor

doronbehar commented Oct 15, 2025

Please read:

https://github.com/NixOS/nixpkgs/blob/master/pkgs/README.md#commit-conventions

@mcdonc
Copy link
Contributor Author

mcdonc commented Oct 15, 2025

Please read:

https://github.com/NixOS/nixpkgs/blob/master/pkgs/README.md#commit-conventions

Thanks for your patience, Doron. I think I have it right now.

@doronbehar
Copy link
Contributor

doronbehar commented Oct 16, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 452193
Commit: 00cf86e955ecae938a92605f2ee142245fc22047

x86_64-linux

✅ 5 packages built:
  • pigpio
  • python312Packages.pigpio
  • python312Packages.pigpio.dist
  • python313Packages.pigpio
  • python313Packages.pigpio.dist

aarch64-linux

✅ 5 packages built:
  • pigpio
  • python312Packages.pigpio
  • python312Packages.pigpio.dist
  • python313Packages.pigpio
  • python313Packages.pigpio.dist

@doronbehar doronbehar added this pull request to the merge queue Oct 16, 2025
Merged via the queue into NixOS:master with commit f853a4a Oct 16, 2025
25 checks passed
@nixpkgs-ci nixpkgs-ci bot added 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. labels Oct 16, 2025
@doronbehar doronbehar mentioned this pull request Oct 16, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@doronbehar doronbehar doronbehar approved these changes

Assignees

No one assigned

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mcdonc @doronbehar