Skip to content

nano-wallet: 25.1 -> 28.2#452172

Merged
vcunat merged 1 commit intoNixOS:masterfrom
yzhou216:nano-wallet-bump
Oct 27, 2025
Merged

nano-wallet: 25.1 -> 28.2#452172
vcunat merged 1 commit intoNixOS:masterfrom
yzhou216:nano-wallet-bump

Conversation

@yzhou216
Copy link
Contributor

@yzhou216 yzhou216 commented Oct 15, 2025 •
edited
Loading

Resolves #389209

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Oct 15, 2025
@andrewzah
Copy link
Contributor

andrewzah commented Oct 19, 2025

This update sets the minimum cmake version to 3.14, which fixes the build issue noted in #445447.

@andrewzah

This comment was marked as outdated.

Sign in to view
@Sigmanificient Sigmanificient mentioned this pull request Oct 19, 2025
Open
@andrewzah

This comment was marked as outdated.

Sign in to view
@andrewzah andrewzah removed the request for review from Sigmanificient October 19, 2025 16:48
@yzhou216 yzhou216 force-pushed the nano-wallet-bump branch 2 times, most recently from bedd738 to e749c78 Compare October 19, 2025 22:41
@yzhou216 yzhou216 changed the title WIP: nano-wallet: 25.1 -> 28.2 nano-wallet: 25.1 -> 28.2 Oct 19, 2025
@yzhou216
Copy link
Contributor Author

yzhou216 commented Oct 20, 2025

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 452172
Commit: e749c7868f735dc51b2b9547677d75f4b20a0054 (subsequent changes)
Merge: 809978c86235090a28e0f29c0a39cb7b2e1cdac8

Logs: https://github.com/yzhou216/nixpkgs-review-gha/actions/runs/18637832517

Download packages from cache:
  • x86_64-linux 
    nix-store -r --add-root nixpkgs-pr-452172-x86_64-linux \
  --option binary-caches 'https://cache.nixos.org/ https://yzhou216.cachix.org' \
  --option trusted-public-keys '
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  yzhou216.cachix.org-1:O7nGwQnLGGBGE8zYFMipVzPVN956FcV57y9SqwEP+O8=
  ' \
  /nix/store/hjc1qjaji2ig6zms1f65ngksnk2bs403-nano-wallet-28.2
  • aarch64-linux 
    nix-store -r --add-root nixpkgs-pr-452172-aarch64-linux \
  --option binary-caches 'https://cache.nixos.org/ https://yzhou216.cachix.org' \
  --option trusted-public-keys '
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  yzhou216.cachix.org-1:O7nGwQnLGGBGE8zYFMipVzPVN956FcV57y9SqwEP+O8=
  ' \
  /nix/store/v6sr8sikqx3x28q2751j9vck0zzi8f1p-nano-wallet-28.2

x86_64-linux

✅ 1 package built:
  • nano-wallet

aarch64-linux

✅ 1 package built:
  • nano-wallet

x86_64-darwin

✅ No rebuilds

aarch64-darwin

✅ No rebuilds

@yzhou216 yzhou216 marked this pull request as ready for review October 20, 2025 00:32
@vcunat vcunat added this pull request to the merge queue Oct 27, 2025
Merged via the queue into NixOS:master with commit d58f0b6 Oct 27, 2025
29 of 31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mmahut mmahut Awaiting requested review from mmahut

@RaghavSood RaghavSood Awaiting requested review from RaghavSood

@jluttine jluttine Awaiting requested review from jluttine

Assignees

No one assigned

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Update Request: nano-wallet 25.1 → 27.1

3 participants

@yzhou216 @andrewzah @vcunat